Notify Sync client when underlying Store is closed

When Store is closed, the Sync client should be closed too

Author: Shubham

objectbox/store.py

@@ -127,6 +127,7 @@ def __init__(self,
         """
 
         self._c_store = None
+        self._close_listeners: list[Callable[[], None]] = []
         if not c_store:
             options = StoreOptions()
             try:
@@ -272,6 +273,9 @@ def write_tx(self):
 
     def close(self):
         """Close database."""
+        for listener in self._close_listeners.values():
+            listener()
+        self._close_listeners.clear()
         c_store_to_close = self._c_store
         if c_store_to_close:
             self._c_store = None
@@ -288,3 +292,6 @@ def remove_db_files(db_dir: str):
 
     def c_store(self):
         return self._c_store
+
+    def add_store_close_listener(self, on_store_close: Callable[[], None]):
+        self._close_listeners.append(on_store_close)

objectbox/sync.py

@@ -156,6 +156,14 @@ def __init__(self, store: Store, server_urls: list[str],
                                                    c.c_array_pointer(self.__server_urls, ctypes.c_char_p),
                                                    len(self.__server_urls))
 
+        self.__store.add_store_close_listener(on_store_close=self.__close_sync_client_func())
+
+    def __close_sync_client_func(self):
+        def close_sync_client():
+            self.close()
+
+        return close_sync_client
+
     def set_credentials(self, credentials: SyncCredentials):
         self.__credentials = credentials
         if isinstance(credentials, SyncCredentialsNone):

tests/test_sync.py

@@ -95,3 +95,12 @@ def test_multiple_credentials(test_store):
         SyncCredentials.jwt_refresh_token("token3"),
         SyncCredentials.jwt_custom_token("token4")
     ])
+
+
+def test_client_closed_when_store_closed(test_store):
+    server_urls = ["ws://localhost:9999"]
+    client = SyncClient(test_store, server_urls)
+
+    assert not client.is_closed()
+    test_store.close()
+    assert client.is_closed()