Skip to content

Commit 01a7e6b

Browse files
committed
Don't check recipients for the testSendSelfReviewCompletionEmailToReviewers test because they are non-deterministic.
1 parent 8577602 commit 01a7e6b

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

server/src/test/java/com/objectcomputing/checkins/services/EmailHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ public static void validateEmail(String action, String fromName,
1818
if (partialBody != null && !partialBody.isEmpty()) {
1919
assertTrue(event.get(4).contains(partialBody));
2020
}
21-
assertEquals(recipients, event.get(5));
21+
if (recipients != null && !recipients.isEmpty()) {
22+
assertEquals(recipients, event.get(5));
23+
}
2224
}
2325
}

server/src/test/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,10 @@ void testSendSelfReviewCompletionEmailToReviewers() {
277277
feedbackRequestServices.sendSelfReviewCompletionEmailToReviewers(feedbackRequest, reviewAssignmentsSet);
278278

279279
// This should equal the number of review assignments.
280+
// The order in which emails are sent is random. We will not be
281+
// checking the recipient.
280282
assertEquals(2, emailSender.events.size());
281-
EmailHelper.validateEmail("SEND_EMAIL", "null", "null", "firstName lastName has finished their self-review for Self-Review Test.", "firstName lastName has completed their self-review", reviewer02.getWorkEmail(), emailSender.events.getFirst());
283+
EmailHelper.validateEmail("SEND_EMAIL", "null", "null", "firstName lastName has finished their self-review for Self-Review Test.", "firstName lastName has completed their self-review", null, emailSender.events.getFirst());
282284
}
283285

284286
@Test

0 commit comments

Comments
 (0)