2024-11-20 - test-case fix

Author: Luch76

server/src/test/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestControllerTest.java

@@ -1793,12 +1793,23 @@ void testUpdateSubmitDateNotAuthorizedToExternalRecipient() {
         feedbackReq.setSubmitDate(LocalDate.now());
         final FeedbackRequestUpdateDTO dto = updateDTO(feedbackReq);
 
-        final HttpRequest<?> request = HttpRequest.PUT("", dto)
+        final HttpRequest<?> requestHttp = HttpRequest.PUT("", dto)
                 .basicAuth(pdl.getWorkEmail(), RoleType.Constants.PDL_ROLE);
+
+        // Access by un-assigned PDL is allowed since the recipient is an external recipient
+        final HttpResponse<FeedbackRequestResponseDTO> response = client.toBlocking().exchange(requestHttp, FeedbackRequestResponseDTO.class);
+
+        assertEquals(HttpStatus.OK, response.getStatus());
+        assertTrue(response.getBody().isPresent());
+        assertResponseEqualsEntity(feedbackReq, response.getBody().get());
+
+        /*
         final HttpClientResponseException responseException = assertThrows(HttpClientResponseException.class, () ->
                 client.toBlocking().exchange(request, Map.class));
+                client.toBlocking().exchange(requestHttp, Map.class));
 
         assertUnauthorized(responseException);
+        */
     }
 
     @Test