Skip to content

Commit 0e088c6

Browse files
committed
Use review assignemnts to detect a lack of review period members, as well as missing reviewers.
1 parent ce2ec7b commit 0e088c6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

web-ui/src/components/reviews/TeamReviews.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -647,9 +647,9 @@ const TeamReviews = ({ onBack, periodId }) => {
647647
if (!period.closeDate) return 'No close date was specified.';
648648
if (!period.periodStartDate) return 'No period-start-date was specified.';
649649
if (!period.periodEndDate) return 'No period-end-date was specified.';
650-
if (teamMembers.length === 0) return 'No members were added.';
651-
const haveReviewers = teamMembers.every(
652-
member => getReviewers(member).length > 0
650+
if (assignments.length === 0) return 'No members were added.';
651+
const haveReviewers = assignments.every(
652+
assignment => assignment.reviewerId != null
653653
);
654654
if (!haveReviewers) return 'One or more members have no reviewer.';
655655
return null; // no validation errors

0 commit comments

Comments
 (0)