Merge branch 'develop' into feature-2645/feedback-request-add-ability-to-request-feedback-from-external-source

Author: Luch76

server/build.gradle

@@ -7,7 +7,7 @@ plugins {
     id "jacoco"
 }
 
-version "0.8.6"
+version "0.8.7"
 group "com.objectcomputing.checkins"
 
 repositories {

web-ui/.nvmrc

@@ -1 +1 @@
-lts/*
+stable/*

web-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "web-ui",
-  "version": "0.8.6",
+  "version": "0.8.7",
   "private": true,
   "type": "module",
   "dependencies": {
@@ -76,7 +76,7 @@
     ]
   },
   "devDependencies": {
-    "@ladle/react": "^4.0.3",
+    "@ladle/react": "^4.1.2",
     "@testing-library/jest-dom": "^6.4.5",
     "@testing-library/react": "^14.2.2",
     "@testing-library/react-hooks": "^8.0.1",
@@ -92,7 +92,7 @@
     "happy-dom": "^15.10.2",
     "jest-fetch-mock": "^3.0.3",
     "jsdom": "^24.0.0",
-    "msw": "^2.2.13",
+    "msw": "^2.6.4",
     "prettier": "3.2.5",
     "prop-types": "^15.8.1",
     "react-test-renderer": "^18.2.0",

web-ui/src/App.jsx

@@ -65,7 +65,7 @@ const theme = extendTheme({
   components: {
     MuiButtonBase: {
       defaultProps: {
-        disableRipple: !!process.env.VITEST_WORKER_ID, // No more ripple...only when testing.
+        disableRipple: typeof process !== 'undefined' && !!process.env.VITEST_WORKER_ID, // No more ripple...only when testing.
       },
     },
     MuiCssBaseline: {

web-ui/src/api/notifications.js

@@ -3,7 +3,7 @@ import { resolve } from './api.js';
 const emailNotificationURL = '/services/email-notifications';
 const emailURL = '/services/email';
 const testEmailURL = import.meta.env.VITE_APP_API_URL
-  ? import.meta.env.VITE_APP_URL + '/feedback/submit?request='
+  ? import.meta.env.VITE_APP_API_URL + '/feedback/submit?request='
   : 'http://localhost:8080/feedback/submit?request=';
 
 export const sendReminderNotification = async (

web-ui/src/components/reviews/TeamReviews.jsx

@@ -647,9 +647,9 @@ const TeamReviews = ({ onBack, periodId }) => {
     if (!period.closeDate) return 'No close date was specified.';
     if (!period.periodStartDate) return 'No period-start-date was specified.';
     if (!period.periodEndDate) return 'No period-end-date was specified.';
-    if (teamMembers.length === 0) return 'No members were added.';
-    const haveReviewers = teamMembers.every(
-      member => getReviewers(member).length > 0
+    if (assignments.length === 0) return 'No members were added.';
+    const haveReviewers = assignments.every(
+      assignment => assignment.reviewerId != null
     );
     if (!haveReviewers) return 'One or more members have no reviewer.';
     return null; // no validation errors