Skip to content

Commit 25a2caa

Browse files
authored
Merge pull request #2857 from objectcomputing/bugfix-2814/add-debug-logging
Added logging to help debug development deployment.
2 parents 1e2d061 + 3c18218 commit 25a2caa

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
import jakarta.validation.Valid;
2626
import jakarta.validation.constraints.NotNull;
2727

28+
import org.slf4j.Logger;
29+
import org.slf4j.LoggerFactory;
30+
2831
import java.net.URI;
2932
import java.time.LocalDate;
3033
import java.util.Set;
@@ -36,6 +39,7 @@
3639
@ExecuteOn(TaskExecutors.BLOCKING)
3740
@Tag(name = "pulse-responses")
3841
public class PulseResponseController {
42+
private static final Logger LOG = LoggerFactory.getLogger(PulseResponseController.class);
3943

4044
private final PulseResponseService pulseResponseServices;
4145
private final MemberProfileServices memberProfileServices;
@@ -146,13 +150,22 @@ public HttpResponse<PulseResponse> externalPulseResponse(
146150
@Header("X-Slack-Request-Timestamp") String timestamp,
147151
@Body String requestBody,
148152
HttpRequest<?> request) {
153+
// DEBUG Only
154+
LOG.info(requestBody);
155+
149156
// Validate the request
150157
if (slackSignatureVerifier.verifyRequest(signature,
151158
timestamp, requestBody)) {
159+
// DEBUG Only
160+
LOG.info("Request has been verified");
161+
152162
PulseResponseCreateDTO pulseResponseDTO =
153163
SlackPulseResponseConverter.get(memberProfileServices,
154164
requestBody);
155165

166+
// DEBUG Only
167+
LOG.info("Request has been converted");
168+
156169
// Create the pulse response
157170
PulseResponse pulseResponse = pulseResponseServices.unsecureSave(
158171
new PulseResponse(

server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
import com.objectcomputing.checkins.services.memberprofile.MemberProfile;
55
import com.objectcomputing.checkins.services.memberprofile.MemberProfileServices;
66

7+
import org.slf4j.Logger;
8+
import org.slf4j.LoggerFactory;
9+
710
import com.fasterxml.jackson.databind.ObjectMapper;
811
import com.fasterxml.jackson.core.type.TypeReference;
912
import com.fasterxml.jackson.core.JsonProcessingException;
@@ -13,6 +16,8 @@
1316
import java.time.LocalDate;
1417

1518
public class SlackPulseResponseConverter {
19+
private static final Logger LOG = LoggerFactory.getLogger(SlackPulseResponseConverter.class);
20+
1621
public static PulseResponseCreateDTO get(
1722
MemberProfileServices memberProfileServices, String body) {
1823
final String key = "payload=";
@@ -50,11 +55,14 @@ public static PulseResponseCreateDTO get(
5055

5156
return response;
5257
} catch(JsonProcessingException ex) {
58+
LOG.error(ex.getMessage());
5359
throw new BadArgException(ex.getMessage());
5460
} catch(NumberFormatException ex) {
61+
LOG.error(ex.getMessage());
5562
throw new BadArgException("Pulse scores must be integers");
5663
}
5764
} else {
65+
LOG.error(body);
5866
throw new BadArgException("Invalid pulse response body");
5967
}
6068
}
@@ -70,6 +78,7 @@ private static String getMappedValue(Map<String, Object> map,
7078
}
7179

7280
if (required) {
81+
LOG.error("Expected {}.{} was not found", key, valueKey);
7382
throw new BadArgException(
7483
String.format("Expected %s.%s was not found", key, valueKey));
7584
} else {

0 commit comments

Comments
 (0)