Merge pull request #2690 from objectcomputing/bugfix-2689/allow-launch-today

Allowed launch for today

Author: mkimberlin

.github/workflows/gradle-build-feature.yml

@@ -16,10 +16,10 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:

.github/workflows/gradle-build-native-feature.yml

@@ -16,10 +16,10 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up GraalVM 21
         uses: graalvm/[email protected]
         with:

.github/workflows/gradle-build-production.yml

@@ -21,10 +21,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:

.github/workflows/gradle-build-publish.yml

@@ -10,10 +10,10 @@ jobs:
       packages: write
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v2-beta
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:

.github/workflows/gradle-deploy-develop.yml

@@ -15,10 +15,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up Temurin 21
         uses: actions/setup-java@v4
         with:

.github/workflows/gradle-deploy-native-develop.yml

@@ -15,10 +15,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Set up Node LTS
+      - name: Set up Node Stable
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '22'
       - name: Set up GraalVM 21
         uses: graalvm/[email protected]
         with:

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java

@@ -24,6 +24,7 @@
 import org.slf4j.LoggerFactory;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
+import java.time.LocalTime;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
@@ -162,7 +163,7 @@ public ReviewPeriod update(@NotNull ReviewPeriod reviewPeriod) {
             if (launchDate == null) {
                 throw new BadArgException("Cannot open a review period without a launch date.");
             }
-            if (launchDate.isBefore(LocalDateTime.now())) {
+            if (launchDate.isBefore(LocalDateTime.now().with(LocalTime.MIN))) {
                 throw new BadArgException("Cannot open a review period with a launch date in the past.");
             }
         }

server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java

@@ -701,7 +701,7 @@ void deleteReviewPeriodWithFeedbackRequests() {
 
     @Test
     void testOpenAReviewPeriodWithBadLaunchTime() {
-        LocalDateTime launchDate = LocalDateTime.now().minusMinutes(1);
+        LocalDateTime launchDate = LocalDateTime.now().minusDays(1);
         LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
         LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
         LocalDateTime startDate = launchDate.minusDays(30);