Merge pull request #2892 from objectcomputing/feature-2888/view-closed-self-reviews

Feature 2888/view closed self reviews

Author: mkimberlin

web-ui/src/components/reviews/TeamReviews.jsx

@@ -172,7 +172,7 @@ const TeamReviews = ({ onBack, periodId }) => {
   useEffect(() => {
     const myId = currentUser?.id;
     const supervisors = selectSupervisors(state);
-    const isManager = supervisors.some(s => s.id === myId);
+    const isManager = supervisors.some(s => s?.id === myId);
     const period = selectReviewPeriod(state, periodId);
     if (period) {
       setApprovalState(period.reviewStatus === ReviewStatus.AWAITING_APPROVAL);

web-ui/src/components/reviews/periods/ReviewPeriods.jsx

@@ -327,8 +327,13 @@ const ReviewPeriods = ({ onPeriodSelected, mode }) => {
         case ReviewStatus.OPEN:
           onPeriodSelected(id);
           break;
+        case ReviewStatus.CLOSED:
+          if (mode === selfReviewMode) {
+            onPeriodSelected(id);
+          }
+          break;
         default:
-          // We do nothing if the status is CLOSED or UNKNOWN.
+          // We do nothing if the status is UNKNOWN.
           break;
       }
     },