Merge pull request #2644 from objectcomputing/review_assignment_test

Updated the review assignment controller test to reflect the latest change to the review period controller.

Author: mkimberlin

server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewAssignmentControllerTest.java

@@ -146,12 +146,13 @@ void testGETFindAssignmentsByPeriodIdDefaultAssignments() {
 
         final HttpResponse<Set<ReviewAssignment>> response = client.toBlocking().exchange(request, Argument.setOf(ReviewAssignment.class));
 
+        // A review period only has default review assignments added to it when
+        // the review period is created through the controller.  And, they are
+        // no longer added to the review period when retrieving the review
+        // assignments for a specific review period.  Therefore, this review
+        // period should have zero review assignments associated with it.
         assertNotNull(response.body());
-        assertEquals(3, Objects.requireNonNull(response.body()).size());
-        assertTrue(response.body().stream().anyMatch(ra -> ra.getRevieweeId().equals(memberOne.getId())));
-        assertTrue(response.body().stream().anyMatch(ra -> ra.getRevieweeId().equals(memberTwo.getId())));
-        assertTrue(response.body().stream().anyMatch(ra -> ra.getRevieweeId().equals(memberThree.getId())));
-        assertEquals(HttpStatus.OK, response.getStatus());
+        assertEquals(0, Objects.requireNonNull(response.body()).size());
     }
 
     @Test
@@ -287,4 +288,4 @@ void deleteReviewAssignmentWithoutPermissions() {
         assertNotNull(responseException.getResponse());
         assertEquals(HttpStatus.FORBIDDEN, responseException.getStatus());
     }
-}
+}