Skip to content

Commit 46ca7d6

Browse files
committed
Simplified if logic.
1 parent 4d42a39 commit 46ca7d6

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

server/src/main/java/com/objectcomputing/checkins/services/feedback_request/FeedbackRequestServicesImpl.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -303,13 +303,9 @@ public List<FeedbackRequest> findByValues(UUID creatorId, UUID requesteeId, UUID
303303
} else if (request != null) {
304304
if (currentUserId.equals(request.getCreatorId()) ||
305305
isSupervisor(request.getRequesteeId(), currentUserId) ||
306-
currentUserId.equals(request.getRecipientId())) {
306+
currentUserId.equals(request.getRecipientId()) ||
307+
selfRevieweeIsCurrentUserReviewee(request, currentUserId)) {
307308
visible = true;
308-
} else {
309-
if (selfRevieweeIsCurrentUserReviewee(request,
310-
currentUserId)) {
311-
visible = true;
312-
}
313309
}
314310
}
315311
return visible;

0 commit comments

Comments
 (0)