Create a path for getting system settings without a permissions check to enable system level functionality

Author: mkimberlin

server/src/main/java/com/objectcomputing/checkins/notifications/email/MailJetFactory.java

@@ -31,12 +31,12 @@ MailjetClient getClient() {
         String mj_apikey_private;
 
         try {
-            mj_apikey_public = settingsServices.findByName(SettingOption.MJ_APIKEY_PUBLIC.name()).getValue();
+            mj_apikey_public = settingsServices.systemFindByName(SettingOption.MJ_APIKEY_PUBLIC.name()).getValue();
         } catch (NotFoundException e) {
             mj_apikey_public = "";
         }
         try {
-            mj_apikey_private = settingsServices.findByName(SettingOption.MJ_APIKEY_PRIVATE.name()).getValue();
+            mj_apikey_private = settingsServices.systemFindByName(SettingOption.MJ_APIKEY_PRIVATE.name()).getValue();
         } catch (NotFoundException e) {
             mj_apikey_private = "";
         }

server/src/main/java/com/objectcomputing/checkins/notifications/email/MailJetSender.java

@@ -35,15 +35,15 @@ public class MailJetSender implements EmailSender {
 
     private String getFromAddress() {
         try {
-            return settingsServices.findByName(SettingOption.FROM_ADDRESS.name()).getValue();
+            return settingsServices.systemFindByName(SettingOption.FROM_ADDRESS.name()).getValue();
         } catch (NotFoundException e) {
             return "";
         }
     }
 
     private String getFromName() {
         try {
-            return settingsServices.findByName(SettingOption.FROM_NAME.name()).getValue();
+            return settingsServices.systemFindByName(SettingOption.FROM_NAME.name()).getValue();
         } catch (NotFoundException e) {
             return "";
         }
@@ -104,12 +104,12 @@ public void sendEmail(String fromName, String fromAddress, String subject, Strin
         String mj_apikey_public;
         String mj_apikey_private;
         try {
-            mj_apikey_public = settingsServices.findByName(SettingOption.MJ_APIKEY_PUBLIC.name()).getValue();
+            mj_apikey_public = settingsServices.systemFindByName(SettingOption.MJ_APIKEY_PUBLIC.name()).getValue();
         } catch (NotFoundException e) {
             mj_apikey_public = "";
         }
         try {
-            mj_apikey_private = settingsServices.findByName(SettingOption.MJ_APIKEY_PRIVATE.name()).getValue();
+            mj_apikey_private = settingsServices.systemFindByName(SettingOption.MJ_APIKEY_PRIVATE.name()).getValue();
         } catch (NotFoundException e) {
             mj_apikey_private = "";
         }

server/src/main/java/com/objectcomputing/checkins/services/file/FileServicesImpl.java

@@ -95,7 +95,7 @@ protected void getCheckinDocuments(
     private String getRootDirId() {
         String rootDirId;
         try {
-            rootDirId = settingsServices.findByName(SettingOption.DIRECTORY_ID.name()).getValue();
+            rootDirId = settingsServices.systemFindByName(SettingOption.DIRECTORY_ID.name()).getValue();
         }
         catch (NotFoundException e ) {
             rootDirId = "";

server/src/main/java/com/objectcomputing/checkins/services/pulse/PulseServicesImpl.java

@@ -78,7 +78,7 @@ public void notifyUsers(LocalDate check) {
                              .with(TemporalAdjusters.firstInMonth(emailDay));
 
       try {
-        Setting freq = settingsServices.findByName("PULSE_EMAIL_FREQUENCY");
+        Setting freq = settingsServices.systemFindByName("PULSE_EMAIL_FREQUENCY");
         if (frequency.containsKey(freq.getValue())) {
           setting = freq.getValue();
         } else {

server/src/main/java/com/objectcomputing/checkins/services/settings/SettingsServices.java

@@ -13,6 +13,8 @@ public interface SettingsServices {
 
     Setting findByName(@NotNull String name);
 
+    Setting systemFindByName(@NotNull String name);
+
     List<Setting> findAllSettings();
 
     boolean delete(UUID id);

server/src/main/java/com/objectcomputing/checkins/services/settings/SettingsServicesImpl.java

@@ -53,6 +53,12 @@ public Setting findByName(@NotNull String name) {
                 .orElseThrow(() -> new NotFoundException("Setting with name " + name + " not found."));
     }
 
+    @Override
+    public Setting systemFindByName(@NotNull String name) {
+        return settingsRepository.findByName(name)
+                .orElseThrow(() -> new NotFoundException("Setting with name " + name + " not found."));
+    }
+
     @Override
     @RequiredPermission(Permission.CAN_VIEW_SETTINGS)
     public List<Setting> findAllSettings() {