Skip to content

Commit 4c76421

Browse files
committed
Send bulk email instead of individual emails.
1 parent cecb128 commit 4c76421

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -451,20 +451,21 @@ void sendSelfReviewEmail(UUID reviewPeriodId, SelfReviewDate date) {
451451
}
452452
}
453453

454-
for(MemberProfile recipient : recipients) {
455-
// Customize the email content using the template.
456-
String content = String.format(template,
457-
webAddress,
458-
reviewPeriodId.toString(),
459-
recipient.getFirstName(),
460-
dateAsString(reviewPeriod.get()
461-
.getSelfReviewCloseDate()),
462-
webAddress);
463-
464-
// Send out the email to the individual.
465-
emailSender.sendEmail(null, null, subject, content,
466-
recipient.getWorkEmail());
467-
}
454+
List<String> addresses = recipients.stream()
455+
.map(p -> p.getWorkEmail()).toList();
456+
457+
// Customize the email content using the template.
458+
String content = String.format(template,
459+
webAddress,
460+
reviewPeriodId.toString(),
461+
dateAsString(reviewPeriod.get()
462+
.getSelfReviewCloseDate()),
463+
webAddress);
464+
465+
// Send out the email to everyone.
466+
emailSender.sendEmail(null, null, subject, content,
467+
recipients.toArray(
468+
new String[recipients.size()]));
468469
} catch(Exception ex) {
469470
LOG.error("Send Self-Review Email: " + ex.toString());
470471
}

server/src/main/resources/mjml/self_review_reminder.mjml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<mj-text>
2222
<h2>Self-Review Reminder!</h2>
2323
</mj-text>
24-
<mj-text font-size="16px">Dear %s,</mj-text>
24+
<mj-text font-size="16px">Greetings,</mj-text>
2525
<mj-text font-size="16px">This is a friendly reminder to complete your self-reviews by %s. <strong></strong></mj-text>
2626
<mj-text font-size="16px">To access your self-review click the button above, or visit <a href="%s">Check-Ins</a> and find "Self-Reviews" under the "Feedback" menu.</mj-text>
2727
</mj-column>
@@ -32,4 +32,4 @@
3232
</mj-column>
3333
</mj-section>
3434
</mj-body>
35-
</mjml>
35+
</mjml>

0 commit comments

Comments
 (0)