Skip to content

Commit 508486c

Browse files
committed
2024-10-16 - Create assignments upon creation of review-object
1 parent fc5ee05 commit 508486c

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewAssignmentServices.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@ public interface ReviewAssignmentServices {
1616
void delete(UUID id);
1717
Set<ReviewAssignment> findAllByReviewPeriodIdAndReviewerId(UUID reviewPeriodId, @Nullable UUID reviewerId);
1818

19+
Set<ReviewAssignment> defaultReviewAssignments(UUID reviewPeriodId);
1920
}

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewAssignmentServicesImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void delete(UUID id) {
109109
}
110110
}
111111

112-
private Set<ReviewAssignment> defaultReviewAssignments(UUID reviewPeriodId) {
112+
public Set<ReviewAssignment> defaultReviewAssignments(UUID reviewPeriodId) {
113113
Set<ReviewAssignment> reviewAssignments = new HashSet<>();
114114

115115
memberProfileRepository.findAll().forEach(memberProfile -> {

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodController.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@
3333
public class ReviewPeriodController {
3434

3535
private final ReviewPeriodServices reviewPeriodServices;
36+
private final ReviewAssignmentServices reviewAssignmentServices;
3637

37-
public ReviewPeriodController(ReviewPeriodServices reviewPeriodServices) {
38+
public ReviewPeriodController(ReviewPeriodServices reviewPeriodServices, ReviewAssignmentServices reviewAssignmentServices) {
3839
this.reviewPeriodServices = reviewPeriodServices;
40+
this.reviewAssignmentServices = reviewAssignmentServices;
3941
}
4042

4143
/**
@@ -47,11 +49,17 @@ public ReviewPeriodController(ReviewPeriodServices reviewPeriodServices) {
4749
@Post
4850
@RequiredPermission(Permission.CAN_CREATE_REVIEW_PERIOD)
4951
public HttpResponse<ReviewPeriod> createReviewPeriod(@Body @Valid ReviewPeriodCreateDTO period, HttpRequest<?> request) {
52+
HttpResponse httpResponse;
53+
Set<ReviewAssignment> reviewAssignments;
54+
5055
ReviewPeriod reviewPeriod = reviewPeriodServices.save(period.convertToEntity());
51-
return HttpResponse.created(reviewPeriod)
56+
httpResponse = HttpResponse.created(reviewPeriod)
5257
.headers(headers -> headers
5358
.location(URI.create(String.format("%s/%s", request.getPath(), reviewPeriod.getId())))
5459
);
60+
reviewAssignments = reviewAssignmentServices.defaultReviewAssignments(reviewPeriod.getId());
61+
reviewAssignmentServices.saveAll(reviewPeriod.getId(), reviewAssignments.stream().toList(), true);
62+
return httpResponse;
5563
}
5664

5765
/**

0 commit comments

Comments
 (0)