Fixed tests and made the Pulse POST to slack non-blocking.

Author: ocielliottc

server/src/main/java/com/objectcomputing/checkins/services/pulse/PulseSlackPoster.java

@@ -39,10 +39,9 @@ public void send() {
                                            .getSlack().getWebhookUrl();
         if (slackWebHook != null && !slackBlocks.isEmpty()) {
             // POST it to Slack.
-            BlockingHttpClient client = slackClient.toBlocking();
             HttpRequest<String> request = HttpRequest.POST(slackWebHook,
                                                            slackBlocks);
-            client.exchange(request);
+            slackClient.exchange(request);
         }
     }
 

server/src/test/java/com/objectcomputing/checkins/services/pulse/PulseServicesTest.java

@@ -97,7 +97,7 @@ void testBiWeeklySendEmail() {
         final Setting setting = new Setting(pulseSettingName, pulseBiWeekly);
         settingsServices.save(setting);
 
-        pulseServices.sendPendingEmail(biWeeklyDate);
+        pulseServices.notifyUsers(biWeeklyDate);
         assertEquals(1, emailSender.events.size());
 
         EmailHelper.validateEmail("SEND_EMAIL", "null", "null",
@@ -112,7 +112,7 @@ void testWeeklySendEmail() {
         final Setting setting = new Setting(pulseSettingName, pulseWeekly);
         settingsServices.save(setting);
 
-        pulseServices.sendPendingEmail(weeklyDate);
+        pulseServices.notifyUsers(weeklyDate);
         assertEquals(1, emailSender.events.size());
 
         EmailHelper.validateEmail("SEND_EMAIL", "null", "null",
@@ -127,7 +127,7 @@ void testMonthlySendEmail() {
         final Setting setting = new Setting(pulseSettingName, pulseMonthly);
         settingsServices.save(setting);
 
-        pulseServices.sendPendingEmail(monthlyDate);
+        pulseServices.notifyUsers(monthlyDate);
         assertEquals(1, emailSender.events.size());
 
         EmailHelper.validateEmail("SEND_EMAIL", "null", "null",
@@ -142,7 +142,7 @@ void testDuplicateSendEmail() {
         final Setting setting = new Setting(pulseSettingName, pulseMonthly);
         settingsServices.save(setting);
 
-        pulseServices.sendPendingEmail(monthlyDate);
+        pulseServices.notifyUsers(monthlyDate);
         // This should be zero because email was already sent on this date.
         assertEquals(0, emailSender.events.size());
     }
@@ -152,13 +152,13 @@ void testNoSendEmail() {
         final Setting setting = new Setting(pulseSettingName, pulseBiWeekly);
         settingsServices.save(setting);
 
-        pulseServices.sendPendingEmail(weeklyDate);
+        pulseServices.notifyUsers(weeklyDate);
         // This should be zero because, when set to bi-weekly, email is sent on
         // the first, third, and fifth Monday of the month.
         assertEquals(0, emailSender.events.size());
 
         final LocalDate nonMonday = weeklyDate.plus(1, ChronoUnit.DAYS);
-        pulseServices.sendPendingEmail(nonMonday);
+        pulseServices.notifyUsers(nonMonday);
         // This should be zero because the date is not a Monday.
         assertEquals(0, emailSender.events.size());
     }

server/src/test/resources/application-test.yml

@@ -45,9 +45,13 @@ check-ins:
       slack:
         webhook-url: https://bogus.objectcomputing.com/slack
         bot-token: BOGUS_TOKEN
+    pulse-response:
+      slack:
+        signing-secret: BOGUS_SIGNING_SECRET
+        webhook-url: https://bogus.objectcomputing.com/slack
 ---
 aes:
   key: BOGUS_TEST_KEY
 ---
 github-credentials:
-  github_token: "test github token"
+  github_token: "test github token"