Skip to content

Commit 67c8df8

Browse files
committed
Switch from a scheduled task to being triggered when the check services runs.
1 parent 918a1d0 commit 67c8df8

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

server/src/main/java/com/objectcomputing/checkins/services/request_notifications/CheckServicesImpl.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import com.objectcomputing.checkins.services.feedback_request.FeedbackRequestServicesImpl;
66
import com.objectcomputing.checkins.services.reviews.ReviewPeriodServices;
77
import com.objectcomputing.checkins.services.pulse.PulseServices;
8+
import com.objectcomputing.checkins.services.slack.kudos.KudosChannelReader;
9+
810
import jakarta.inject.Singleton;
911
import org.slf4j.Logger;
1012
import org.slf4j.LoggerFactory;
@@ -20,15 +22,18 @@ public class CheckServicesImpl implements CheckServices {
2022
private final FeedbackRequestRepository feedbackRequestRepository;
2123
private final PulseServices pulseServices;
2224
private final ReviewPeriodServices reviewPeriodServices;
25+
private final KudosChannelReader kudosChannelReader;
2326

2427
public CheckServicesImpl(FeedbackRequestServicesImpl feedbackRequestServices,
2528
FeedbackRequestRepository feedbackRequestRepository,
2629
PulseServices pulseServices,
27-
ReviewPeriodServices reviewPeriodServices) {
30+
ReviewPeriodServices reviewPeriodServices,
31+
KudosChannelReader kudosChannelReader) {
2832
this.feedbackRequestServices = feedbackRequestServices;
2933
this.feedbackRequestRepository = feedbackRequestRepository;
3034
this.pulseServices = pulseServices;
3135
this.reviewPeriodServices = reviewPeriodServices;
36+
this.kudosChannelReader = kudosChannelReader;
3237
}
3338

3439
@Override
@@ -43,6 +48,7 @@ public boolean sendScheduledEmails() {
4348
}
4449
pulseServices.notifyUsers(today);
4550
reviewPeriodServices.sendNotifications(today);
51+
kudosChannelReader.readChannel();
4652
return true;
4753
}
4854

server/src/main/java/com/objectcomputing/checkins/services/slack/kudos/KudosChannelReader.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
import com.slack.api.model.Message;
77

8-
import io.micronaut.scheduling.annotation.Scheduled;
9-
108
import org.slf4j.Logger;
119
import org.slf4j.LoggerFactory;
1210

@@ -33,7 +31,6 @@ public class KudosChannelReader {
3331
@Inject
3432
private SlackKudosCreator slackKudosCreator;
3533

36-
@Scheduled(fixedDelay = "10m")
3734
public void readChannel() {
3835
Optional<KudosChannelReadTime> readTime =
3936
kudosChannelReadTimeStore.findById(KudosChannelReadTime.key);

0 commit comments

Comments
 (0)