Skip to content

Commit 6ddafa2

Browse files
committed
2024-10-31 - external-recip get-all
1 parent 8ef5420 commit 6ddafa2

File tree

3 files changed

+52
-6
lines changed

3 files changed

+52
-6
lines changed

server/src/main/java/com/objectcomputing/checkins/services/feedback_external_recipient/FeedbackExternalRecipientController.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,41 @@ public HttpResponse<FeedbackExternalRecipientResponseDTO> save(@Body @Valid @Not
5555
.headers(headers -> headers.location(URI.create("/feedback_external_recipient/" + savedFeedbackExternalRecipient.getId())));
5656
}
5757

58+
/*
59+
@Get("/{?email, firstName, lastName, companyName}")
60+
public List<FeedbackExternalRecipientResponseDTO> findByValues(@Nullable String email, @Nullable String firstName, @Nullable String lastName, @Nullable String companyName) {
61+
return this.feedbackExternalRecipientServices.findByValues(email, firstName, lastName, companyName)
62+
.stream()
63+
.map(this::fromEntity)
64+
.toList();
65+
}
66+
*/
67+
68+
/**
69+
* Return list of all external-recipients used for feedback-requests
70+
*
71+
* @return list of {@link FeedbackExternalRecipientResponseDTO}
72+
*/
73+
@Get("/findAll")
74+
public List<FeedbackExternalRecipientResponseDTO> findAll() {
75+
return this.feedbackExternalRecipientServices.findAll()
76+
.stream()
77+
.map(this::fromEntity)
78+
.toList();
79+
}
80+
81+
/**
82+
* Get external recipient (for feedback requests) by ID
83+
*
84+
* @param id {@link UUID} ID of the external-recipient
85+
* @return {@link FeedbackExternalRecipientResponseDTO}
86+
*/
87+
@Get("/{id}")
88+
public HttpResponse<FeedbackExternalRecipientResponseDTO> getById(UUID id) {
89+
FeedbackExternalRecipient feedbackExternalRecipient = this.feedbackExternalRecipientServices.getById(id);
90+
return HttpResponse.created(fromEntity(feedbackExternalRecipient));
91+
}
92+
5893
private FeedbackExternalRecipient fromDTO(FeedbackExternalRecipientCreateDTO dto) {
5994
FeedbackExternalRecipient object = new FeedbackExternalRecipient();
6095
object.setEmail(dto.getEmail());

server/src/main/java/com/objectcomputing/checkins/services/feedback_external_recipient/FeedbackExternalRecipientServices.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public interface FeedbackExternalRecipientServices {
1313

1414
FeedbackExternalRecipient getById(UUID id);
1515

16-
List<FeedbackExternalRecipient> findByValues(String email, String firstName, String lastName, String companyName);
16+
//List<FeedbackExternalRecipient> findByValues(String email, String firstName, String lastName, String companyName);
17+
18+
List<FeedbackExternalRecipient> findAll();
1719

1820
}

server/src/main/java/com/objectcomputing/checkins/services/feedback_external_recipient/FeedbackExternalRecipientServicesImpl.java

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
package com.objectcomputing.checkins.services.feedback_external_recipient;
22

33
import com.objectcomputing.checkins.exceptions.NotFoundException;
4+
import io.micronaut.core.annotation.Nullable;
45
import jakarta.inject.Singleton;
56

6-
import java.util.List;
7-
import java.util.Optional;
8-
import java.util.UUID;
7+
import java.util.*;
98

109
@Singleton
1110
public class FeedbackExternalRecipientServicesImpl implements FeedbackExternalRecipientServices {
@@ -42,7 +41,17 @@ public FeedbackExternalRecipient getById(UUID id) {
4241
}
4342

4443
@Override
45-
public List<FeedbackExternalRecipient> findByValues(String email, String firstName, String lastName, String companyName) {
46-
return List.of();
44+
public List<FeedbackExternalRecipient> findAll() {
45+
return feedbackExternalRecipientRepository.findAll();
4746
}
47+
48+
/*
49+
@Override
50+
public List<FeedbackExternalRecipient> findByValues(@Nullable String email, @Nullable String firstName, @Nullable String lastName, @Nullable String companyName) {
51+
List<FeedbackExternalRecipient> feedbackExternalRecipients = new ArrayList<>(feedbackExternalRecipientRepository.search());
52+
53+
return feedbackExternalRecipients;
54+
}
55+
*/
56+
4857
}

0 commit comments

Comments
 (0)