Skip to content

Commit 7a371a0

Browse files
committed
Skip messages posted by bot users too.
1 parent 00cc1dd commit 7a371a0

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

server/src/main/java/com/objectcomputing/checkins/services/slack/kudos/SlackKudosCreator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,10 @@ public class SlackKudosCreator {
5050

5151
public void store(List<Message> messages) {
5252
for (Message message : messages) {
53-
// User messages do not have a sub-type.
54-
if (message.getSubtype() == null) {
53+
// User messages do not have a sub-type. A bot user can send
54+
// messages. They will not have a subtype, but they will have a bot
55+
// id. We want to skip those too.
56+
if (message.getSubtype() == null && message.getBotId() == null) {
5557
try {
5658
AutomatedKudosDTO kudosDTO = createFromMessage(message);
5759
if (kudosDTO.getRecipientIds().size() == 0) {
@@ -74,7 +76,7 @@ public void store(List<Message> messages) {
7476

7577
private AutomatedKudosDTO createFromMessage(Message message) {
7678
String userId = message.getUser();
77-
MemberProfile sender = lookupUser(userId);
79+
MemberProfile sender = lookupUser(userId);
7880
List<UUID> recipients = new ArrayList<>();
7981
String text = processText(message.getText(), recipients);
8082
return new AutomatedKudosDTO(text, userId, sender.getId(), recipients);

0 commit comments

Comments
 (0)