Fixed test errors.

Author: ocielliottc

server/src/main/java/com/objectcomputing/checkins/services/slack/SlackSubmissionHandler.java

@@ -19,12 +19,16 @@
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.core.JsonProcessingException;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.util.Map;
 import java.nio.charset.StandardCharsets;
 
 @Singleton
 public class SlackSubmissionHandler {
-    private final String typeKey = "type";
+    private static final Logger LOG = LoggerFactory.getLogger(SlackSubmissionHandler.class);
+    private static final String typeKey = "type";
 
     private final PulseResponseService pulseResponseServices;
     private final SlackSignatureVerifier slackSignatureVerifier;
@@ -96,6 +100,7 @@ public HttpResponse externalResponse(String signature,
                     }
                 } catch(JsonProcessingException ex) {
                     // Fall through to the bottom...
+                    LOG.error("externalResponse: " + ex.toString());
                 }
             }
         } else {

server/src/test/java/com/objectcomputing/checkins/services/SlackSearchReplacement.java

@@ -25,10 +25,20 @@ public SlackSearchReplacement(CheckInsConfiguration checkInsConfiguration) {
         super(checkInsConfiguration);
     }
 
+    @Override
+    public String findChannelName(String channelId) {
+        return channels.containsKey(channelId) ?
+                   channels.get(channelId) : null;
+    }
+
     @Override
     public String findChannelId(String channelName) {
-        return channels.containsKey(channelName) ?
-                   channels.get(channelName) : null;
+        for (Map.Entry<String, String> entry : channels.entrySet()) {
+            if (entry.getValue().equals(channelName)) {
+                return entry.getKey();
+            }
+        }
+        return null;
     }
 
     @Override

server/src/test/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseControllerTest.java

@@ -37,6 +37,7 @@
 import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 import java.time.Instant;
+import java.net.URLEncoder;
 
 import static com.objectcomputing.checkins.services.role.RoleType.Constants.ADMIN_ROLE;
 import static com.objectcomputing.checkins.services.role.RoleType.Constants.MEMBER_ROLE;
@@ -536,9 +537,10 @@ void testUpdateInvalidDatePulseResponse() {
     @Test
     void testCreateAPulseResponseFromSlack() {
         MemberProfile memberProfile = createADefaultMemberProfile();
-        slackSearch.users.put("SLACK_ID_HI", memberProfile.getWorkEmail());
+        String slackId = "SLACK_ID_HI";
+        slackSearch.users.put(slackId, memberProfile.getWorkEmail());
 
-        final String rawBody = "payload=%7B%22type%22%3A+%22view_submission%22%2C+%22user%22%3A+%7B%22id%22%3A+%22SLACK_ID_HI%22%7D%2C+%22view%22%3A+%7B%22id%22%3A+%22VNHU13V36%22%2C+%22type%22%3A+%22modal%22%2C+%22state%22%3A+%7B%22values%22%3A+%7B%22internalNumber%22%3A+%7B%22internalScore%22%3A+%7B%22selected_option%22%3A+%7B%22type%22%3A+%22radio_buttons%22%2C+%22value%22%3A+%224%22%7D%7D%7D%2C+%22internalText%22%3A+%7B%22internalFeelings%22%3A+%7B%22type%22%3A+%22plain_text_input%22%2C+%22value%22%3A+%22I+am+a+robot.%22%7D%7D%2C+%22externalNumber%22%3A+%7B%22externalScore%22%3A+%7B%22selected_option%22%3A+%7B%22type%22%3A+%22radio_buttons%22%2C+%22value%22%3A+%225%22%7D%7D%7D%2C+%22externalText%22%3A+%7B%22externalFeelings%22%3A+%7B%22type%22%3A+%22plain_text_input%22%2C+%22value%22%3A+%22You+are+a+robot.%22%7D%7D%7D%7D%7D%7D";
+        final String rawBody = getSlackPulsePayload(slackId);
 
         long currentTime = Instant.now().getEpochSecond();
         String timestamp = String.valueOf(currentTime);
@@ -603,4 +605,53 @@ private MemberProfile profile(String key) {
     private UUID id(String key) {
         return profile(key).getId();
     }
+
+    private String getSlackPulsePayload(String slackId) {
+        return "payload=" +
+               URLEncoder.encode(String.format("""
+{
+  "type": "view_submission",
+  "user": {
+    "id": "%s"
+  },
+  "view": {
+    "id": "VNHU13V36",
+    "type": "modal",
+    "callback_id": "pulseSubmission",
+    "state": {
+      "values": {
+        "internalNumber": {
+          "internalScore": {
+            "selected_option": {
+              "type": "radio_buttons",
+              "value": "4"
+            }
+          }
+        },
+        "internalText": {
+          "internalFeelings": {
+            "type": "plain_text_input",
+            "value": "I am a robot."
+          }
+        },
+        "externalNumber": {
+          "externalScore": {
+            "selected_option": {
+              "type": "radio_buttons",
+              "value": "5"
+            }
+          }
+        },
+        "externalText": {
+          "externalFeelings": {
+            "type": "plain_text_input",
+            "value": "You are a robot."
+          }
+        }
+      }
+    }
+  }
+}
+""", slackId));
+    }
 }

server/src/test/resources/application-test.yml

@@ -45,6 +45,7 @@ check-ins:
       webhook-url: https://bogus.objectcomputing.com/slack
       bot-token: BOGUS_TOKEN
       signing-secret: BOGUS_SIGNING_SECRET
+      kudos-channel: SLACK_KUDOS_CHANNEL_ID
 ---
 aes:
   key: BOGUS_TEST_KEY