Merge branch 'develop' into bugfix-2672/address-test-warnings

Author: mkimberlin

server/build.gradle

@@ -7,7 +7,7 @@ plugins {
     id "jacoco"
 }
 
-version "0.8.5"
+version "0.8.6"
 group "com.objectcomputing.checkins"
 
 repositories {

server/src/main/java/com/objectcomputing/checkins/services/memberprofile/birthday/BirthDayServicesImpl.java

@@ -23,6 +23,13 @@ public BirthDayServicesImpl(MemberProfileServices memberProfileServices) {
     public List<BirthDayResponseDTO> findByValue(String[] months, Integer[] daysOfMonth) {
         Set<MemberProfile> memberProfiles = memberProfileServices.findByValues(null, null, null, null, null, null, false);
         List<MemberProfile> memberProfileAll = new ArrayList<>(memberProfiles);
+        if (months == null && daysOfMonth == null) {
+            // If nothing was passed in, get all members without birthdays.
+            memberProfileAll = memberProfileAll
+                .stream()
+                .filter(member -> member.getBirthDate() == null)
+                .toList();
+        }
         if (months != null) {
             for (String month : months) {
                 if (month != null) {
@@ -66,7 +73,9 @@ private List<BirthDayResponseDTO> profileToBirthDateResponseDto(List<MemberProfi
                 BirthDayResponseDTO birthDayResponseDTO = new BirthDayResponseDTO();
                 birthDayResponseDTO.setUserId(member.getId());
                 birthDayResponseDTO.setName(member.getFirstName() + "" +member.getLastName());
-                birthDayResponseDTO.setBirthDay(member.getBirthDate().getMonthValue() + "/" +member.getBirthDate().getDayOfMonth());
+                if (member.getBirthDate() != null) {
+                    birthDayResponseDTO.setBirthDay(member.getBirthDate().getMonthValue() + "/" +member.getBirthDate().getDayOfMonth());
+                }
                 birthDays.add(birthDayResponseDTO);
             }
         }

server/src/main/java/com/objectcomputing/checkins/services/reports/CompensationHistory.java

@@ -23,7 +23,8 @@ public class CompensationHistory extends CSVProcessor {
     public record Compensation(
             UUID memberId,
             LocalDate startDate,
-            float amount
+            String amount,
+            String totalComp
     ) {
     }
 
@@ -45,11 +46,13 @@ protected void loadImpl(MemberProfileRepository memberProfileRepository,
             if (date == null) {
               LOG.error("Unable to parse date: {}", startDate);
             } else {
+              String value = csvRecord.get("compensation");
               Compensation comp = new Compensation(
                       memberProfile.get().getId(),
                       date,
-                      Float.parseFloat(csvRecord.get("compensation")
-                                                .replaceAll("[^\\d\\.,]", "")));
+                      value == null ? null : value.replaceAll("[^\\d\\.,]", ""),
+                      csvRecord.get("totalComp")
+              );
               history.add(comp);
             }
           } else {

server/src/test/java/com/objectcomputing/checkins/services/reports/ReportDataControllerTest.java

@@ -185,9 +185,10 @@ void validateReportData(JsonNode node, MemberProfile user) {
 
     // Compensation History
     ArrayNode comp = (ArrayNode)node.get("compensationHistory");
-    assertEquals(5, comp.size());
+    assertEquals(10, comp.size());
     assertEquals(memberId, comp.get(0).get("memberId").asText());
     assertTrue(comp.get(0).get("amount").asDouble() > 0);
+    assertFalse(comp.get(9).get("totalComp").asText().isEmpty());
 
     // Current Information
     JsonNode curr = node.get("currentInformation");

server/src/test/java/com/objectcomputing/checkins/services/reports/data/compensationHistory.csv

@@ -1,11 +1,21 @@
-"emailAddress","startDate","compensation"
-"[email protected]","1/1/2024","100000.00"
-"[email protected]","1/1/2023","95000.00"
-"[email protected]","1/1/2022","90000.00"
-"[email protected]","1/1/2021","85000.00"
-"[email protected]","1/1/2020","80000.00"
-"[email protected]","2/1/2024","100000.00"
-"[email protected]","2/1/2023","95000.00"
-"[email protected]","2/1/2022","90000.00"
-"[email protected]","2/1/2021","85000.00"
-"[email protected]","2/1/2020","80000.00"
+"emailAddress","startDate","compensation","totalComp"
+"[email protected]","1/1/2024","100000.00",
+"[email protected]","1/1/2023","95000.00",
+"[email protected]","1/1/2022","90000.00",
+"[email protected]","1/1/2021","85000.00",
+"[email protected]","1/1/2020","80000.00",
+"[email protected]","2/1/2024","100000.00",
+"[email protected]","2/1/2023","95000.00",
+"[email protected]","2/1/2022","90000.00",
+"[email protected]","2/1/2021","85000.00",
+"[email protected]","2/1/2020","80000.00",
+"[email protected]","2024",,"103000.00"
+"[email protected]","2023",,"98000.00"
+"[email protected]","2022",,"93000.00"
+"[email protected]","2021",,"88000.00"
+"[email protected]","2020",,"83000.00"
+"[email protected]","2024",,"103000.00"
+"[email protected]","2023",,"98000.00"
+"[email protected]","2022",,"93000.00"
+"[email protected]","2021",,"88000.00"
+"[email protected]","2020",,"83000.00"

web-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "web-ui",
-  "version": "0.8.5",
+  "version": "0.8.6",
   "private": true,
   "type": "module",
   "dependencies": {
@@ -89,7 +89,7 @@
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-vitest": "^0.5.4",
     "globals": "^15.0.0",
-    "happy-dom": "^15.10.1",
+    "happy-dom": "^15.10.2",
     "jest-fetch-mock": "^3.0.3",
     "jsdom": "^24.0.0",
     "msw": "^2.2.13",

web-ui/src/api/birthdayanniversary.js

@@ -25,12 +25,28 @@ export const getTodaysCelebrations = async cookie => {
 
 export const getBirthdays = async (months, cookie) => {
   const results = [];
-  for (let month of months) {
+  if (months) {
+    for (let month of months) {
+      const res = await resolve({
+        url: `${birthdayReportUrl}?month=${month}`,
+        headers: { 'X-CSRF-Header': cookie, Accept: 'application/json' }
+      });
+      if (res.error) {
+        console.error(res.error);
+      } else {
+        results.push(...res.payload.data);
+      }
+    }
+  } else {
     const res = await resolve({
-      url: `${birthdayReportUrl}?month=${month}`,
+      url: birthdayReportUrl,
       headers: { 'X-CSRF-Header': cookie, Accept: 'application/json' }
     });
-    results.push(...res.payload.data);
+    if (res.error) {
+      console.error(res.error);
+    } else {
+      results.push(...res.payload.data);
+    }
   }
   return results;
 };

web-ui/src/api/notifications.js

@@ -3,7 +3,7 @@ import { resolve } from './api.js';
 const emailNotificationURL = '/services/email-notifications';
 const emailURL = '/services/email';
 const testEmailURL = import.meta.env.VITE_APP_API_URL
-  ? import.meta.env.VITE_APP_URL + '/feedback/submit?request='
+  ? import.meta.env.VITE_APP_API_URL + '/feedback/submit?request='
   : 'http://localhost:8080/feedback/submit?request=';
 
 export const sendReminderNotification = async (

web-ui/src/components/guild-results/EditGuildModal.jsx

@@ -11,7 +11,8 @@ import {
   FormControlLabel,
   Modal,
   Switch,
-  TextField
+  TextField,
+  Checkbox,
 } from '@mui/material';
 import Autocomplete from '@mui/material/Autocomplete';
 import './EditGuildModal.css';
@@ -166,18 +167,19 @@ const EditGuildModal = ({ guild = {}, open, onSave, onClose, headerText }) => {
             value={editedGuild.name ? editedGuild.name : ''}
             onChange={e => setGuild({ ...editedGuild, name: e.target.value })}
           />
-          {guild.id && <FormControlLabel
-            control={
-              <Switch
-                checked={editedGuild.active}
-                onChange={event => {
-                  const { checked } = event.target;
-                  setGuild({ ...editedGuild, active: checked });
-                }}
-              />
-            }
+          {guild.id && (<>
+          <Checkbox
+            id="guild-active-input"
             label="Active"
-          />}
+            variant="outlined"
+            className="halfWidth"
+            checked={editedGuild.active ? editedGuild.active : false}
+            onChange={event => {
+              const { checked } = event.target;
+              setGuild({ ...editedGuild, active: checked });
+            }}
+          /> Active
+          </>)}
         </div>
         <div>
           <FormControlLabel

web-ui/src/components/guild-results/EditGuildModal.spec.jsx

@@ -34,12 +34,14 @@ const testGuild = {
   guildMembers: [
     { id: 125, name: 'Guild Member' },
     { id: 126, name: 'Other Member' }
-  ]
+  ],
+  active: true,
 };
 
 const emptyGuild = {
   name: 'Test Guild',
-  description: 'A guild used for testing.'
+  description: 'A guild used for testing.',
+  active: true,
 };
 
 const currentUserProfile = {