Skip to content

Commit 93dd2a1

Browse files
committed
Ensure pulse response data is verified in expected order.
1 parent d6c3cdd commit 93dd2a1

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseServicesImpl.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public PulseResponseServicesImpl(
4949
@Override
5050
public PulseResponse save(PulseResponse pulseResponse) {
5151
if (pulseResponse != null) {
52+
verifyPulseData(pulseResponse);
5253
final UUID memberId = pulseResponse.getTeamMemberId();
5354
UUID currentUserId = currentUserServices.getCurrentUser().getId();
5455
if (memberId != null &&
@@ -80,13 +81,14 @@ public PulseResponse unsecureSave(PulseResponse pulseResponse) {
8081
submitted = existing.isPresent();
8182
}
8283
if (!submitted) {
84+
verifyPulseData(pulseResponse);
8385
return saveCommon(pulseResponse);
8486
}
8587
}
8688
return null;
8789
}
8890

89-
private PulseResponse saveCommon(PulseResponse pulseResponse) {
91+
private void verifyPulseData(PulseResponse pulseResponse) {
9092
final UUID memberId = pulseResponse.getTeamMemberId();
9193
LocalDate pulseSubDate = pulseResponse.getSubmissionDate();
9294
if (pulseResponse.getId() != null) {
@@ -97,7 +99,9 @@ private PulseResponse saveCommon(PulseResponse pulseResponse) {
9799
} else if (pulseSubDate.isBefore(LocalDate.EPOCH) || pulseSubDate.isAfter(LocalDate.MAX)) {
98100
throw new BadArgException(String.format("Invalid date for pulseresponse submission date %s", memberId));
99101
}
102+
}
100103

104+
private PulseResponse saveCommon(PulseResponse pulseResponse) {
101105
PulseResponse pulseResponseRet = pulseResponseRepo.save(pulseResponse);
102106

103107
// Send low pulse survey score if appropriate

0 commit comments

Comments
 (0)