Removed Mockito from MemberPhotoServiceImplTest.

Author: ocielliottc

server/src/main/java/com/objectcomputing/checkins/services/memberprofile/memberphoto/GooglePhotoAccessorImpl.java

@@ -18,7 +18,8 @@
 import java.util.Optional;
 
 @Singleton
-class GooglePhotoAccessorImpl implements GooglePhotoAccessor {
+// Public so that this class can be replaced during testing.
+public class GooglePhotoAccessorImpl implements GooglePhotoAccessor {
 
     private static final Logger LOG = LoggerFactory.getLogger(GooglePhotoAccessorImpl.class);
 

server/src/test/java/com/objectcomputing/checkins/services/GooglePhotoAccessorImplReplacement.java

@@ -0,0 +1,38 @@
+package com.objectcomputing.checkins.services;
+
+import com.google.api.services.directory.model.UserPhoto;
+import com.objectcomputing.checkins.services.memberprofile.memberphoto.GooglePhotoAccessorImpl;
+import com.objectcomputing.checkins.services.memberprofile.memberphoto.GooglePhotoAccessor;
+
+import java.util.List;
+import java.util.Map;
+import java.util.HashMap;
+import java.util.Base64;
+
+import jakarta.inject.Singleton;
+import io.micronaut.core.util.StringUtils;
+import io.micronaut.context.annotation.Replaces;
+import io.micronaut.context.annotation.Requires;
+
+@Singleton
+@Replaces(GooglePhotoAccessorImpl.class)
+@Requires(property = "replace.googlephotoaccessorimpl", value = StringUtils.TRUE)
+public class GooglePhotoAccessorImplReplacement implements GooglePhotoAccessor {
+    Map<String, UserPhoto> photos = new HashMap<>();
+
+    public void reset() {
+      photos.clear();
+    }
+
+    public void setUserPhoto(String email, UserPhoto photo) {
+        photos.put(email, photo);
+    }
+
+    @Override
+    public byte[] getPhotoData(String workEmail) {
+        UserPhoto photo = photos.get(workEmail);
+        return photo == null
+            ? new byte[0]
+            : Base64.getUrlDecoder().decode(photo.getPhotoData().getBytes());
+    }
+}

server/src/test/java/com/objectcomputing/checkins/services/memberprofile/memberphoto/MemberPhotoServiceImplTest.java

@@ -1,85 +1,35 @@
 package com.objectcomputing.checkins.services.memberprofile.memberphoto;
 
 import com.google.api.client.googleapis.json.GoogleJsonResponseException;
-import com.google.api.services.directory.Directory;
 import com.google.api.services.directory.model.UserPhoto;
 import com.objectcomputing.checkins.services.TestContainersSuite;
+import com.objectcomputing.checkins.services.GooglePhotoAccessorImplReplacement;
 import com.objectcomputing.checkins.services.memberprofile.MemberProfileServices;
-import com.objectcomputing.checkins.util.googleapiaccess.GoogleApiAccess;
-import io.micronaut.context.env.Environment;
-import org.junit.jupiter.api.AfterAll;
-import org.junit.jupiter.api.BeforeAll;
+import io.micronaut.core.util.StringUtils;
+import io.micronaut.context.annotation.Property;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledInNativeImage;
-import org.mockito.InjectMocks;
-import org.mockito.Mock;
-import org.mockito.MockitoAnnotations;
+import jakarta.inject.Inject;
 
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.mockito.Mockito.reset;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
 
-// Disabled in nativeTest, as we get an exception from Mockito
-//    => java.lang.NoClassDefFoundError: Could not initialize class org.mockito.internal.configuration.plugins.Plugins
-@DisabledInNativeImage
+@Property(name = "replace.googlephotoaccessorimpl", value = StringUtils.TRUE)
 class MemberPhotoServiceImplTest extends TestContainersSuite {
 
-    @Mock
-    private MemberProfileServices mockMemberProfileServices;
-
-    @Mock
-    private GoogleApiAccess mockGoogleApiAccess;
-
-    @Mock
-    private Directory mockDirectory;
-
-    @Mock
-    private Directory.Users mockUsers;
-
-    @Mock
-    private Directory.Users.Photos mockPhotos;
-
-    @Mock
-    private Directory.Users.Photos.Get mockGet;
-
-    @Mock
-    private Environment mockEnvironment;
-
-    @InjectMocks
-    private GooglePhotoAccessorImpl accessor;
+    @Inject
+    private GooglePhotoAccessorImplReplacement googlePhotoAccessorImpl;
 
+    @Inject
     private MemberPhotoServiceImpl service;
 
-    private AutoCloseable mockFinalizer;
-
-    @BeforeAll
-    void initMocks() {
-        mockFinalizer = MockitoAnnotations.openMocks(this);
-    }
-
-    @AfterAll
-    void close() throws Exception {
-        mockFinalizer.close();
-    }
-
     @BeforeEach
-    void resetMocks() {
-        reset(mockMemberProfileServices);
-        reset(mockGoogleApiAccess);
-        reset(mockDirectory);
-        reset(mockUsers);
-        reset(mockPhotos);
-        reset(mockGet);
-        reset(mockEnvironment);
-        service = new MemberPhotoServiceImpl(accessor);
+    void reset() {
+        googlePhotoAccessorImpl.reset();
     }
 
     // happy path
@@ -96,36 +46,20 @@ void testGetImageByEmailAddress() throws IOException {
         testUserPhoto.setKind("test.kind");
         testUserPhoto.setMimeType("test.mime.type");
         testUserPhoto.setPhotoData(new String(testData));
-
-        when(mockGoogleApiAccess.getDirectory()).thenReturn(mockDirectory);
-        when(mockDirectory.users()).thenReturn(mockUsers);
-        when(mockUsers.photos()).thenReturn(mockPhotos);
-        when(mockPhotos.get(testEmail)).thenReturn(mockGet);
-        when(mockGet.execute()).thenReturn(testUserPhoto);
-
+        googlePhotoAccessorImpl.setUserPhoto(testEmail, testUserPhoto);
         final byte[] result = service.getImageByEmailAddress(testEmail);
 
         assertNotNull(result);
         assertEquals(testPhotoData, new String(result, StandardCharsets.UTF_8));
-        verify(mockGoogleApiAccess, times(1)).getDirectory();
-        verify(mockGet, times(1)).execute();
     }
 
     @Test
     void testDirectoryServiceThrowsGoogleJsonResponseException() throws IOException {
-        String testEmail = "[email protected]";
-
-        when(mockGoogleApiAccess.getDirectory()).thenReturn(mockDirectory);
-        when(mockDirectory.users()).thenReturn(mockUsers);
-        when(mockUsers.photos()).thenReturn(mockPhotos);
-        when(mockPhotos.get(testEmail)).thenReturn(mockGet);
-        when(mockGet.execute()).thenThrow(GoogleJsonResponseException.class);
+        String testEmail = "[email protected]";
 
         final byte[] result = service.getImageByEmailAddress(testEmail);
 
         assertNotNull(result);
         assertEquals("", new String(result, StandardCharsets.UTF_8));
-        verify(mockGoogleApiAccess, times(1)).getDirectory();
-        verify(mockGet, times(1)).execute();
     }
 }