Blind attempt at test fix that will probably make everything worse. :-D

Author: mkimberlin

server/src/test/java/com/objectcomputing/checkins/services/fixture/ReviewPeriodFixture.java

@@ -10,12 +10,11 @@
 public interface ReviewPeriodFixture extends RepositoryFixture {
 
     default ReviewPeriod createADefaultReviewPeriod() {
-        LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
-                                                .truncatedTo(ChronoUnit.MILLIS);
-        LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
-        LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
-        LocalDateTime startDate = launchDate.minusDays(30);
-        LocalDateTime endDate = closeDate.minusDays(1);
+        LocalDateTime launchDate = LocalDateTime.now().plusDays(1).atStartOfDay();
+        LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+        LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+        LocalDateTime startDate = launchDate.minusDays(31);
+        LocalDateTime endDate = launchDate.minusDays(1);
         return getReviewPeriodRepository().save(
           new ReviewPeriod("Period of Time", ReviewStatus.OPEN, null, null,
                            launchDate, selfReviewCloseDate, closeDate,
@@ -27,12 +26,11 @@ default ReviewPeriod createADefaultReviewPeriod(ReviewStatus reviewStatus) {
     }
 
     default ReviewPeriod createADefaultReviewPeriod(ReviewStatus reviewStatus, UUID templateId) {
-        LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
-                                                .truncatedTo(ChronoUnit.MILLIS);
-        LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
-        LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
-        LocalDateTime startDate = launchDate.minusDays(30);
-        LocalDateTime endDate = closeDate.minusDays(1);
+        LocalDateTime launchDate = LocalDateTime.now().plusDays(1).atStartOfDay();
+        LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+        LocalDateTime closeDate = selfReviewCloseDate.plusDays(3);
+        LocalDateTime startDate = launchDate.minusDays(31);
+        LocalDateTime endDate = launchDate.minusDays(1);
         return getReviewPeriodRepository().save(
           new ReviewPeriod("Period of Time", reviewStatus, templateId, null,
                            launchDate, selfReviewCloseDate, closeDate,
@@ -43,12 +41,12 @@ default ReviewPeriod createADefaultReviewPeriod(
                              LocalDateTime launchDate,
                              ReviewStatus reviewStatus,
                              UUID templateId, UUID selfReviewTemplateId) {
-        launchDate = launchDate.truncatedTo(ChronoUnit.MILLIS);
+        launchDate = launchDate.atStartOfDay();
 
-        LocalDateTime selfReviewCloseDate = launchDate.plusDays(4);
-        LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
-        LocalDateTime startDate = launchDate.minusDays(30);
-        LocalDateTime endDate = closeDate.minusDays(1);
+        LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+        LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+        LocalDateTime startDate = launchDate.minusDays(31);
+        LocalDateTime endDate = launchDate.minusDays(1);
         return getReviewPeriodRepository().save(
           new ReviewPeriod("Specific Launch Date", reviewStatus, templateId,
                            selfReviewTemplateId,
@@ -57,32 +55,29 @@ default ReviewPeriod createADefaultReviewPeriod(
     }
 
     default ReviewPeriod createASecondaryReviewPeriod() {
-        LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
-                                                .truncatedTo(ChronoUnit.MILLIS);
-        LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
-        LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
-        LocalDateTime startDate = launchDate.minusDays(30);
-        LocalDateTime endDate = closeDate.minusDays(1);
+        LocalDateTime launchDate = LocalDateTime.now().plusDays(1).atStartOfDay();
+        LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+        LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+        LocalDateTime startDate = launchDate.minusDays(31);
+        LocalDateTime endDate = launchDate.minusDays(1);
         return getReviewPeriodRepository().save(
           new ReviewPeriod("Period of Play", ReviewStatus.OPEN, null, null,
                            launchDate, selfReviewCloseDate, closeDate,
                            startDate, endDate));
     }
 
     default ReviewPeriod createAClosedReviewPeriod() {
-        LocalDateTime launchDate = LocalDateTime.now().plusMinutes(1)
-                                                .truncatedTo(ChronoUnit.MILLIS);
-        LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
-        LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
-        LocalDateTime startDate = launchDate.minusDays(30);
-        LocalDateTime endDate = closeDate.minusDays(1);
+        LocalDateTime launchDate = LocalDateTime.now().plusDays(1).atStartOfDay();
+        LocalDateTime selfReviewCloseDate = launchDate.plusDays(2);
+        LocalDateTime closeDate = selfReviewCloseDate.plusDays(2);
+        LocalDateTime startDate = launchDate.minusDays(31);
+        LocalDateTime endDate = launchDate.minusDays(1);
         return createAClosedReviewPeriod(startDate, endDate);
     }
 
     default ReviewPeriod createAClosedReviewPeriod(
                            LocalDateTime periodStart, LocalDateTime periodEnd) {
-        LocalDateTime launchDate = periodEnd.plusMinutes(1)
-                                                .truncatedTo(ChronoUnit.MILLIS).plusDays(1);
+        LocalDateTime launchDate = periodEnd.plusDays(1).atStartOfDay();
         LocalDateTime selfReviewCloseDate = launchDate.plusDays(3);
         LocalDateTime closeDate = selfReviewCloseDate.plusDays(7);
         return getReviewPeriodRepository().save(