Skip to content

Commit a225086

Browse files
committed
Show only active teams and guilds when creating the member selector dialog or kudos dialog.
1 parent db99c9f commit a225086

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

web-ui/src/components/kudos_dialog/KudosDialog.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { AppContext } from '../../context/AppContext';
2929
import {
3030
selectCsrfToken,
3131
selectCurrentUser,
32-
selectNormalizedTeams,
32+
selectActiveTeams,
3333
selectOrderedCurrentMemberProfiles,
3434
selectProfile
3535
} from '../../context/selectors';
@@ -65,7 +65,7 @@ const KudosDialog = ({ open, recipient, teamId, onClose }) => {
6565
);
6666

6767
const currentUser = selectCurrentUser(state);
68-
const teams = selectNormalizedTeams(state, '');
68+
const teams = selectActiveTeams(state);
6969
const memberProfiles = selectOrderedCurrentMemberProfiles(state);
7070

7171
const handleSubmit = useCallback(() => {

web-ui/src/components/member_selector/member_selector_dialog/MemberSelectorDialog.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ import { AppContext } from '../../../context/AppContext';
3737
import {
3838
selectCsrfToken,
3939
selectCurrentMembers,
40-
selectGuilds,
40+
selectActiveGuilds,
4141
selectMappedUserRoles,
4242
selectRoles,
4343
selectSkills,
4444
selectSubordinates,
4545
selectSupervisors,
4646
selectTeamMembersBySupervisorId,
47-
selectTeams
47+
selectActiveTeams,
4848
} from '../../../context/selectors';
4949
import { UPDATE_TOAST } from '../../../context/actions';
5050
import { getMembersByTeam } from '../../../api/team';
@@ -172,14 +172,14 @@ const MemberSelectorDialog = ({
172172
const getFilterOptions = () => {
173173
switch (filterType) {
174174
case FilterType.TEAM:
175-
const teams = selectTeams(state);
175+
const teams = selectActiveTeams(state);
176176
return {
177177
options: teams,
178178
label: team => team.name,
179179
equals: (team1, team2) => team1.id === team2.id
180180
};
181181
case FilterType.GUILD:
182-
const guilds = selectGuilds(state);
182+
const guilds = selectActiveGuilds(state);
183183
return {
184184
options: guilds,
185185
label: guild => guild.name,

web-ui/src/context/selectors.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,11 +686,21 @@ export const selectNormalizedTeams = createSelector(
686686
})
687687
);
688688

689+
export const selectActiveTeams = createSelector(
690+
selectTeams,
691+
(teams, searchText) => teams?.filter(team => team.active)
692+
);
693+
694+
export const selectActiveGuilds = createSelector(
695+
selectGuilds,
696+
(guilds, searchText) => guilds?.filter(guild => guild.active)
697+
);
698+
689699
export const selectMyGuilds = createSelector(
690700
selectCurrentUserId,
691701
selectGuilds,
692702
(id, guilds) =>
693-
guilds?.filter(guild =>
703+
guilds?.filter(guild => guild.active &&
694704
guild.guildMembers?.some(member => member.memberId === id)
695705
)
696706
);
@@ -699,7 +709,7 @@ export const selectMyTeams = createSelector(
699709
selectCurrentUserId,
700710
selectTeams,
701711
(id, teams) =>
702-
teams?.filter(team =>
712+
teams?.filter(team => team.active &&
703713
team.teamMembers?.some(member => member.memberId === id)
704714
)
705715
);

0 commit comments

Comments
 (0)