Skip to content

Commit a2511a6

Browse files
authored
Merge pull request #2685 from objectcomputing/bugfix-2684/no-supervisor-review-period
If a reviewee does not have a supervisor, use the reviewer for the approval calculations.
2 parents 16e86dc + 57017ec commit a2511a6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

web-ui/src/components/reviews/periods/ReviewPeriodCard.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,10 @@ const ReviewPeriodCard = ({ mode, onSelect, periodId, selfReviews }) => {
9595
const member = currentMembers.find(m => m.id === assignment.revieweeId);
9696
if (member?.supervisorid) {
9797
assignment.revieweeSupervisorId = member.supervisorid;
98+
} else {
99+
// If this person does not have a supervisor, use the reviewer for
100+
// the calculations below.
101+
assignment.revieweeSupervisorId = assignment.reviewerId;
98102
}
99103
}
100104

0 commit comments

Comments
 (0)