Skip to content

Commit a2adc20

Browse files
authored
Merge branch 'develop' into feature-2873/public-kudos-tab
2 parents 5ed94d0 + 1e60cbd commit a2adc20

File tree

3 files changed

+30
-7
lines changed

3 files changed

+30
-7
lines changed

web-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"canvas-confetti": "^1.6.0",
2525
"date-fns": "^2.24.0",
2626
"dayjs": "^1.11.11",
27-
"dompurify": "^3.1.0",
27+
"dompurify": "^3.2.4",
2828
"fuse.js": "^6.4.6",
2929
"html-react-parser": "^5.1.12",
3030
"isomorphic-fetch": "^3.0.0",

web-ui/src/components/kudos/PublicKudosCard.jsx

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,18 @@ const KudosCard = ({ kudos }) => {
5151

5252
const sender = selectProfile(state, kudos.senderId);
5353

54+
const multiTooltip = (num, list) => {
55+
let tooltip = "";
56+
let prefix = "";
57+
for (let member of list.slice(-num)) {
58+
tooltip += prefix + `${member.firstName} ${member.lastName}`;
59+
prefix = ", ";
60+
}
61+
return <Tooltip arrow title={tooltip}>
62+
<Typography>{`+${num}`}</Typography>
63+
</Tooltip>;
64+
};
65+
5466
const getRecipientComponent = useCallback(() => {
5567
if (kudos.recipientTeam) {
5668
return (
@@ -67,7 +79,9 @@ const KudosCard = ({ kudos }) => {
6779
}
6880

6981
return (
70-
<AvatarGroup max={4}>
82+
<AvatarGroup max={4}
83+
renderSurplus={(extra) => multiTooltip(
84+
extra, kudos.recipientMembers)}>
7185
{kudos.recipientMembers.map((member) => (
7286
<Tooltip
7387
arrow
@@ -100,7 +114,9 @@ const KudosCard = ({ kudos }) => {
100114
<CardContent>
101115
<Typography variant="body1"><em>{kudos.message}</em></Typography>
102116
{kudos.recipientTeam && (
103-
<AvatarGroup max={12}>
117+
<AvatarGroup max={12}
118+
renderSurplus={(extra) => multiTooltip(
119+
extra, kudos.recipientMembers)}>
104120
{kudos.recipientMembers.map((member) => (
105121
<Tooltip
106122
arrow

web-ui/yarn.lock

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1540,6 +1540,11 @@
15401540
resolved "https://registry.yarnpkg.com/@types/tough-cookie/-/tough-cookie-4.0.5.tgz#cb6e2a691b70cb177c6e3ae9c1d2e8b2ea8cd304"
15411541
integrity sha512-/Ad8+nIOV7Rl++6f1BdKxFSMgmoqEoYbHRpPcx3JEfv8VRsQe9Z4mCXeJBzxs7mbHY/XOZZuXlRNfhpVPbs6ZA==
15421542

1543+
"@types/trusted-types@^2.0.7":
1544+
version "2.0.7"
1545+
resolved "https://registry.yarnpkg.com/@types/trusted-types/-/trusted-types-2.0.7.tgz#baccb07a970b91707df3a3e8ba6896c57ead2d11"
1546+
integrity sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==
1547+
15431548
"@types/unist@*", "@types/unist@^3.0.0":
15441549
version "3.0.3"
15451550
resolved "https://registry.yarnpkg.com/@types/unist/-/unist-3.0.3.tgz#acaab0f919ce69cce629c2d4ed2eb4adc1b6c20c"
@@ -2944,10 +2949,12 @@ domhandler@^4.2.0, domhandler@^4.2.2:
29442949
dependencies:
29452950
domelementtype "^2.2.0"
29462951

2947-
dompurify@^3.1.0:
2948-
version "3.2.0"
2949-
resolved "https://registry.yarnpkg.com/dompurify/-/dompurify-3.2.0.tgz#53c414317c51503183696fcdef6dd3f916c607ed"
2950-
integrity sha512-AMdOzK44oFWqHEi0wpOqix/fUNY707OmoeFDnbi3Q5I8uOpy21ufUA5cDJPr0bosxrflOVD/H2DMSvuGKJGfmQ==
2952+
dompurify@^3.2.4:
2953+
version "3.2.4"
2954+
resolved "https://registry.yarnpkg.com/dompurify/-/dompurify-3.2.4.tgz#af5a5a11407524431456cf18836c55d13441cd8e"
2955+
integrity sha512-ysFSFEDVduQpyhzAob/kkuJjf5zWkZD8/A9ywSp1byueyuCfHamrCBa14/Oc2iiB0e51B+NpxSl5gmzn+Ms/mg==
2956+
optionalDependencies:
2957+
"@types/trusted-types" "^2.0.7"
29512958

29522959
domutils@^2.4.2, domutils@^2.8.0:
29532960
version "2.8.0"

0 commit comments

Comments
 (0)