Added a test for the slack kudos.

ocielliottc · ocielliottc · commit b4a0c912e052 · 2025-02-11T08:13:18.000-06:00
diff --git a/server/src/main/java/com/objectcomputing/checkins/notifications/social_media/SlackSender.java b/server/src/main/java/com/objectcomputing/checkins/notifications/social_media/SlackSender.java
@@ -46,7 +46,6 @@ public boolean send(List<String> userIds, String slackBlocks) {
                     .builder()
                     .channel(openResponse.getChannel().getId())
                     .blocksAsString(slackBlocks)
-                    .text("This is a test")
                     .build();
 
                 // Send it to Slack
diff --git a/server/src/main/java/com/objectcomputing/checkins/services/slack/SlackSignature.java b/server/src/main/java/com/objectcomputing/checkins/services/slack/SlackSignature.java
@@ -1,5 +1,6 @@
 package com.objectcomputing.checkins.services.slack;
 
+import com.objectcomputing.checkins.exceptions.BadArgException;
 import com.objectcomputing.checkins.configuration.CheckInsConfiguration;
 
 import javax.crypto.Mac;
@@ -12,11 +13,11 @@
 import jakarta.inject.Singleton;
 
 @Singleton
-public class SlackSignatureVerifier {
+public class SlackSignature {
     @Inject
     private CheckInsConfiguration configuration;
 
-    public SlackSignatureVerifier() {}
+    public SlackSignature() {}
 
     public boolean verifyRequest(String slackSignature, String timestamp, String requestBody) {
         try {
@@ -35,7 +36,7 @@ public boolean verifyRequest(String slackSignature, String timestamp, String req
 
             // Compare the computed signature with Slack's signature
             return computedSignature.equals(slackSignature);
-        } catch (Exception e) {
+        } catch (Exception ex) {
             return false;
         }
     }
@@ -64,4 +65,30 @@ private String hmacSha256(String secret, String message) throws Exception {
         }
         return hexString.toString();
     }
+
+    public String generate(String timestamp, String rawBody) {
+        String baseString = "v0:" + timestamp + ":" + rawBody;
+        String secret = configuration.getApplication()
+                                     .getSlack().getSigningSecret();
+
+        try {
+            // Generate HMAC SHA-256 signature
+            Mac mac = Mac.getInstance("HmacSHA256");
+            SecretKeySpec secretKeySpec =
+                new SecretKeySpec(secret.getBytes(StandardCharsets.UTF_8),
+                                  "HmacSHA256");
+            mac.init(secretKeySpec);
+            byte[] hash = mac.doFinal(
+                              baseString.getBytes(StandardCharsets.UTF_8));
+
+            // Convert hash to hex
+            StringBuilder hexString = new StringBuilder();
+            for (byte b : hash) {
+                hexString.append(String.format("%02x", b));
+            }
+            return "v0=" + hexString.toString();
+        } catch (Exception ex) {
+            throw new BadArgException(ex.toString());
+        }
+    }
 }
diff --git a/server/src/main/java/com/objectcomputing/checkins/services/slack/SlackSubmissionHandler.java b/server/src/main/java/com/objectcomputing/checkins/services/slack/SlackSubmissionHandler.java
@@ -31,18 +31,18 @@ public class SlackSubmissionHandler {
     private static final String typeKey = "type";
 
     private final PulseResponseService pulseResponseServices;
-    private final SlackSignatureVerifier slackSignatureVerifier;
+    private final SlackSignature slackSignature;
     private final PulseSlackCommand pulseSlackCommand;
     private final SlackPulseResponseConverter slackPulseResponseConverter;
     private final SlackKudosResponseHandler slackKudosResponseHandler;
 
     public SlackSubmissionHandler(PulseResponseService pulseResponseServices,
-                                  SlackSignatureVerifier slackSignatureVerifier,
+                                  SlackSignature slackSignature,
                                   PulseSlackCommand pulseSlackCommand,
                                   SlackPulseResponseConverter slackPulseResponseConverter,
                                   SlackKudosResponseHandler slackKudosResponseHandler) {
         this.pulseResponseServices = pulseResponseServices;
-        this.slackSignatureVerifier = slackSignatureVerifier;
+        this.slackSignature = slackSignature;
         this.pulseSlackCommand = pulseSlackCommand;
         this.slackPulseResponseConverter = slackPulseResponseConverter;
         this.slackKudosResponseHandler = slackKudosResponseHandler;
@@ -52,8 +52,7 @@ public HttpResponse commandResponse(String signature,
                                         String timestamp,
                                         String requestBody) {
         // Validate the request
-        if (slackSignatureVerifier.verifyRequest(signature,
-                                                 timestamp, requestBody)) {
+        if (slackSignature.verifyRequest(signature, timestamp, requestBody)) {
             // Convert the request body to a map of values.
             FormUrlEncodedDecoder formUrlEncodedDecoder = new FormUrlEncodedDecoder();
             Map<String, Object> body =
@@ -77,8 +76,7 @@ public HttpResponse externalResponse(String signature,
                                          String requestBody,
                                          HttpRequest<?> request) {
         // Validate the request
-        if (slackSignatureVerifier.verifyRequest(signature,
-                                                 timestamp, requestBody)) {
+        if (slackSignature.verifyRequest(signature, timestamp, requestBody)) {
             // Convert the request body to a map of values.
             FormUrlEncodedDecoder formUrlEncodedDecoder =
                 new FormUrlEncodedDecoder();
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/SlackReaderReplacement.java b/server/src/test/java/com/objectcomputing/checkins/services/SlackReaderReplacement.java
@@ -0,0 +1,58 @@
+package com.objectcomputing.checkins.services;
+
+import com.objectcomputing.checkins.services.slack.SlackReader;
+import com.objectcomputing.checkins.configuration.CheckInsConfiguration;
+
+import io.micronaut.context.annotation.Replaces;
+import io.micronaut.context.annotation.Requires;
+import io.micronaut.core.util.StringUtils;
+import io.micronaut.http.HttpResponse;
+import io.micronaut.http.HttpStatus;
+
+import com.slack.api.model.Message;
+
+import jakarta.inject.Singleton;
+
+import java.util.List;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Map;
+import java.time.LocalDateTime;
+import java.time.ZoneId;
+
+@Singleton
+@Replaces(SlackReader.class)
+@Requires(property = "replace.slackreader", value = StringUtils.TRUE)
+public class SlackReaderReplacement extends SlackReader {
+    public final Map<String, List<Message>> channelMessages = new HashMap<>();
+
+    @Override
+    public List<Message> read(String channelId, LocalDateTime last) {
+        List<Message> messages = new ArrayList<>();
+        if (channelMessages.containsKey(channelId)) {
+            long ts = last.atZone(ZoneId.systemDefault())
+                          .toInstant().getEpochSecond();
+            for (Message message : channelMessages.get(channelId)) {
+                long messageTime = Long.parseLong(message.getTs());
+                if (messageTime >= ts) {
+                    messages.add(message);
+                }
+            }
+        }
+        return messages;
+    }
+
+    public void addMessage(String channelId, String userId,
+                           String text, LocalDateTime sendTime) {
+        Message message = new Message();
+        message.setTs(String.valueOf(sendTime.atZone(ZoneId.systemDefault())
+                                             .toInstant().getEpochSecond()));
+        message.setText(text);
+        message.setUser(userId);
+
+        if (!channelMessages.containsKey(channelId)) {
+            channelMessages.put(channelId, new ArrayList<Message>());
+        }
+        channelMessages.get(channelId).add(message);
+    }
+}
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/SlackSenderReplacement.java b/server/src/test/java/com/objectcomputing/checkins/services/SlackSenderReplacement.java
@@ -0,0 +1,37 @@
+package com.objectcomputing.checkins.services;
+
+import com.objectcomputing.checkins.notifications.social_media.SlackSender;
+
+import io.micronaut.context.annotation.Replaces;
+import io.micronaut.context.annotation.Requires;
+import io.micronaut.core.util.StringUtils;
+
+import jakarta.inject.Singleton;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.HashMap;
+
+@Singleton
+@Replaces(SlackSender.class)
+@Requires(property = "replace.slacksender", value = StringUtils.TRUE)
+public class SlackSenderReplacement extends SlackSender {
+    public final Map<String, List<String>> sent = new HashMap<>();
+
+    public void reset() {
+        sent.clear();
+    }
+
+    @Override
+    public boolean send(List<String> userIds, String slackBlocks) {
+        for (String userId : userIds) {
+            if (!sent.containsKey(userId)) {
+                sent.put(userId, new ArrayList<String>());
+            }
+            sent.get(userId).add(slackBlocks);
+        }
+        return true;
+    }
+}
+
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/fixture/AutomatedKudosFixture.java b/server/src/test/java/com/objectcomputing/checkins/services/fixture/AutomatedKudosFixture.java
@@ -0,0 +1,15 @@
+package com.objectcomputing.checkins.services.fixture;
+
+import com.objectcomputing.checkins.services.slack.kudos.AutomatedKudos;
+import com.objectcomputing.checkins.services.slack.kudos.AutomatedKudosRepository;
+
+import java.util.ArrayList;
+import java.util.List;
+
+public interface AutomatedKudosFixture extends RepositoryFixture {
+    default List<AutomatedKudos> getAutomatedKudos() {
+        List<AutomatedKudos> list = new ArrayList<>();
+        getAutomatedKudosRepository().findAll().forEach(list::add);
+        return list;
+    }
+}
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/fixture/RepositoryFixture.java b/server/src/test/java/com/objectcomputing/checkins/services/fixture/RepositoryFixture.java
@@ -43,6 +43,7 @@
 import com.objectcomputing.checkins.services.volunteering.VolunteeringRelationshipRepository;
 import io.micronaut.runtime.server.EmbeddedServer;
 import com.objectcomputing.checkins.services.employee_hours.EmployeeHoursRepository;
+import com.objectcomputing.checkins.services.slack.kudos.AutomatedKudosRepository;
 
 public interface RepositoryFixture {
     EmbeddedServer getEmbeddedServer();
@@ -213,4 +214,8 @@ default DocumentRepository getDocumentRepository() {
     default RoleDocumentationRepository getRoleDocumentationRepository() {
         return getEmbeddedServer().getApplicationContext().getBean(RoleDocumentationRepository.class);
     }
+
+    default AutomatedKudosRepository getAutomatedKudosRepository() {
+        return getEmbeddedServer().getApplicationContext().getBean(AutomatedKudosRepository.class);
+    }
 }
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/kudos/SlackKudosTest.java b/server/src/test/java/com/objectcomputing/checkins/services/kudos/SlackKudosTest.java
diff --git a/server/src/test/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseControllerTest.java b/server/src/test/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseControllerTest.java
