Skip to content

Commit b50e0eb

Browse files
committed
Use the same surplus renderer for team kudos.
1 parent c8826ba commit b50e0eb

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

web-ui/src/components/kudos/PublicKudosCard.jsx

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,18 @@ const KudosCard = ({ kudos }) => {
5151

5252
const sender = selectProfile(state, kudos.senderId);
5353

54+
const multiTooltip = (num, list) => {
55+
let tooltip = "";
56+
let prefix = "";
57+
for (let member of list.slice(-num)) {
58+
tooltip += prefix + `${member.firstName} ${member.lastName}`;
59+
prefix = ", ";
60+
}
61+
return <Tooltip arrow key="multi-member-tooltip" title={tooltip}>
62+
{`+${num}`}
63+
</Tooltip>;
64+
};
65+
5466
const getRecipientComponent = useCallback(() => {
5567
if (kudos.recipientTeam) {
5668
return (
@@ -66,18 +78,6 @@ const KudosCard = ({ kudos }) => {
6678
);
6779
}
6880

69-
const multiTooltip = (num, list) => {
70-
let tooltip = "";
71-
let prefix = "";
72-
for (let member of list.slice(-num)) {
73-
tooltip += prefix + `${member.firstName} ${member.lastName}`;
74-
prefix = ", ";
75-
}
76-
return <Tooltip arrow key="multi-member-tooltip" title={tooltip}>
77-
{`+${num}`}
78-
</Tooltip>;
79-
};
80-
8181
return (
8282
<AvatarGroup max={4}
8383
renderSurplus={(extra) => multiTooltip(
@@ -114,7 +114,9 @@ const KudosCard = ({ kudos }) => {
114114
<CardContent>
115115
<Typography variant="body1"><em>{kudos.message}</em></Typography>
116116
{kudos.recipientTeam && (
117-
<AvatarGroup max={12}>
117+
<AvatarGroup max={12}
118+
renderSurplus={(extra) => multiTooltip(
119+
extra, kudos.recipientMembers)}>
118120
{kudos.recipientMembers.map((member) => (
119121
<Tooltip
120122
arrow

0 commit comments

Comments
 (0)