Skip to content

Commit b70ed9a

Browse files
committed
Allowed launch for today
1 parent a27c0ce commit b70ed9a

File tree

8 files changed

+9
-8
lines changed

8 files changed

+9
-8
lines changed

.github/workflows/gradle-build-feature.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Set up Node LTS
2020
uses: actions/setup-node@v4
2121
with:
22-
node-version: '20'
22+
node-version: '22'
2323
- name: Set up JDK 21
2424
uses: actions/setup-java@v4
2525
with:

.github/workflows/gradle-build-native-feature.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Set up Node LTS
2020
uses: actions/setup-node@v4
2121
with:
22-
node-version: '20'
22+
node-version: '22'
2323
- name: Set up GraalVM 21
2424
uses: graalvm/[email protected]
2525
with:

.github/workflows/gradle-build-production.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Set up Node LTS
2525
uses: actions/setup-node@v4
2626
with:
27-
node-version: '20'
27+
node-version: '22'
2828
- name: Set up JDK 21
2929
uses: actions/setup-java@v4
3030
with:

.github/workflows/gradle-build-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- name: Set up Node LTS
1414
uses: actions/setup-node@v2-beta
1515
with:
16-
node-version: '20'
16+
node-version: '22'
1717
- name: Set up JDK 21
1818
uses: actions/setup-java@v4
1919
with:

.github/workflows/gradle-deploy-develop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Set up Node LTS
1919
uses: actions/setup-node@v4
2020
with:
21-
node-version: '20'
21+
node-version: '22'
2222
- name: Set up Temurin 21
2323
uses: actions/setup-java@v4
2424
with:

.github/workflows/gradle-deploy-native-develop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Set up Node LTS
1919
uses: actions/setup-node@v4
2020
with:
21-
node-version: '20'
21+
node-version: '22'
2222
- name: Set up GraalVM 21
2323
uses: graalvm/[email protected]
2424
with:

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.slf4j.LoggerFactory;
2525
import java.time.LocalDate;
2626
import java.time.LocalDateTime;
27+
import java.time.LocalTime;
2728
import java.util.HashSet;
2829
import java.util.List;
2930
import java.util.Objects;
@@ -162,7 +163,7 @@ public ReviewPeriod update(@NotNull ReviewPeriod reviewPeriod) {
162163
if (launchDate == null) {
163164
throw new BadArgException("Cannot open a review period without a launch date.");
164165
}
165-
if (launchDate.isBefore(LocalDateTime.now())) {
166+
if (launchDate.isBefore(LocalDateTime.now().with(LocalTime.MIN))) {
166167
throw new BadArgException("Cannot open a review period with a launch date in the past.");
167168
}
168169
}

server/src/test/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodControllerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ void deleteReviewPeriodWithFeedbackRequests() {
701701

702702
@Test
703703
void testOpenAReviewPeriodWithBadLaunchTime() {
704-
LocalDateTime launchDate = LocalDateTime.now().minusMinutes(1);
704+
LocalDateTime launchDate = LocalDateTime.now().minusDays(1);
705705
LocalDateTime selfReviewCloseDate = launchDate.plusDays(1);
706706
LocalDateTime closeDate = selfReviewCloseDate.plusDays(1);
707707
LocalDateTime startDate = launchDate.minusDays(30);

0 commit comments

Comments
 (0)