Skip to content

Commit b90adcc

Browse files
committed
Fixed the case of the key for the internal feelings text and removed the debug logging.
1 parent 4c2c206 commit b90adcc

File tree

2 files changed

+2
-28
lines changed

2 files changed

+2
-28
lines changed

server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponseController.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@
2525
import jakarta.validation.Valid;
2626
import jakarta.validation.constraints.NotNull;
2727

28-
import org.slf4j.Logger;
29-
import org.slf4j.LoggerFactory;
30-
3128
import java.net.URI;
3229
import java.time.LocalDate;
3330
import java.util.Set;
@@ -39,8 +36,6 @@
3936
@ExecuteOn(TaskExecutors.BLOCKING)
4037
@Tag(name = "pulse-responses")
4138
public class PulseResponseController {
42-
private static final Logger LOG = LoggerFactory.getLogger(PulseResponseController.class);
43-
4439
private final PulseResponseService pulseResponseServices;
4540
private final MemberProfileServices memberProfileServices;
4641
private final SlackSignatureVerifier slackSignatureVerifier;
@@ -153,15 +148,9 @@ public HttpResponse externalPulseResponse(
153148
@Header("X-Slack-Request-Timestamp") String timestamp,
154149
@Body String requestBody,
155150
HttpRequest<?> request) {
156-
// DEBUG Only
157-
LOG.info(requestBody);
158-
159151
// Validate the request
160152
if (slackSignatureVerifier.verifyRequest(signature,
161153
timestamp, requestBody)) {
162-
// DEBUG Only
163-
LOG.info("Request has been verified");
164-
165154
// Convert the request body to a map of values.
166155
FormUrlEncodedDecoder formUrlEncodedDecoder =
167156
new FormUrlEncodedDecoder();
@@ -174,16 +163,14 @@ public HttpResponse externalPulseResponse(
174163
PulseResponseCreateDTO pulseResponseDTO =
175164
slackPulseResponseConverter.get(memberProfileServices,
176165
(String)body.get(key));
166+
177167
// If we receive a null DTO, that means that this is not the
178168
// actual submission of the form. We can just return 200 so
179169
// that Slack knows to continue without error.
180170
if (pulseResponseDTO == null) {
181171
return HttpResponse.ok();
182172
}
183173

184-
// DEBUG Only
185-
LOG.info("Request has been converted");
186-
187174
// Create the pulse response
188175
PulseResponse pulseResponse =
189176
pulseResponseServices.unsecureSave(

server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/SlackPulseResponseConverter.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ public PulseResponseCreateDTO get(
4545
final Map<String, Object> values =
4646
(Map<String, Object>)state.get("values");
4747

48-
dumpMap(values, "");
49-
5048
// Create the pulse DTO and fill in the values.
5149
PulseResponseCreateDTO response = new PulseResponseCreateDTO();
5250
response.setTeamMemberId(lookupUser(memberProfileServices, map));
@@ -59,7 +57,7 @@ public PulseResponseCreateDTO get(
5957
internalBlock, "internalScore", "selected_option", true)));
6058
// Internal Feelings
6159
response.setInternalFeelings(getMappedValue(
62-
values, "internaltext", "internalFeelings", false));
60+
values, "internalText", "internalFeelings", false));
6361

6462
// External Score
6563
Map<String, Object> externalBlock =
@@ -126,15 +124,4 @@ private UUID lookupUser(MemberProfileServices memberProfileServices,
126124
MemberProfile member = memberProfileServices.findByWorkEmail(email);
127125
return member.getId();
128126
}
129-
130-
// DEBUG Only
131-
private void dumpMap(Map<?, ?> map, String indent) {
132-
for (Map.Entry<?, ?> entry : map.entrySet()) {
133-
LOG.info(indent + entry.getKey() + " : " + entry.getValue());
134-
135-
if (entry.getValue() instanceof Map) {
136-
dumpMap((Map<?, ?>) entry.getValue(), indent + " ");
137-
}
138-
}
139-
}
140127
}

0 commit comments

Comments
 (0)