Skip to content

Commit c2c3a0d

Browse files
committed
Fixed lack of update after updating sent kudos.
1 parent 5a75399 commit c2c3a0d

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

web-ui/src/pages/KudosPage.jsx

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -71,25 +71,29 @@ const KudosPage = () => {
7171
}
7272
}, [csrf, dispatch, currentUser.id]);
7373

74+
const loadAndSetReceivedKudos = () => {
75+
loadReceivedKudos().then((data) => {
76+
if (data) {
77+
const filtered = data.filter((kudo) =>
78+
kudo.recipientMembers.some((member) => member.id === currentUser.id)
79+
);
80+
setReceivedKudos(filtered);
81+
}
82+
});
83+
};
84+
85+
const loadAndSetSentKudos = () => {
86+
loadSentKudos().then((data) => {
87+
if (data) {
88+
setSentKudos(data.filter((kudo) => kudo.senderId === currentUser.id));
89+
}
90+
});
91+
};
92+
7493
useEffect(() => {
7594
if (csrf && currentUser && currentUser.id) {
76-
loadReceivedKudos().then((data) => {
77-
if (data) {
78-
let filtered = data.filter((kudo) =>
79-
kudo.recipientMembers.some((member) => member.id === currentUser.id)
80-
);
81-
setReceivedKudos(filtered);
82-
}
83-
});
84-
85-
loadSentKudos().then((data) => {
86-
if (data) {
87-
let filtered = data.filter(
88-
(kudo) => kudo.senderId === currentUser.id
89-
);
90-
setSentKudos(filtered);
91-
}
92-
});
95+
loadAndSetReceivedKudos();
96+
loadAndSetSentKudos();
9397
}
9498
// eslint-disable-next-line react-hooks/exhaustive-deps
9599
}, [csrf, currentUser, kudosTab]);
@@ -161,12 +165,7 @@ const KudosPage = () => {
161165
<KudosCard
162166
key={k.id}
163167
kudos={k}
164-
onKudosAction={() => {
165-
const updatedKudos = receivedKudos.filter(
166-
(pk) => pk.id !== k.id
167-
);
168-
setReceivedKudos(updatedKudos);
169-
}}
168+
onKudosAction={loadAndSetReceivedKudos}
170169
/>
171170
))}
172171
</div>
@@ -187,7 +186,7 @@ const KudosPage = () => {
187186
<div>
188187
{sentKudos.map((k) => (
189188
<KudosCard key={k.id} kudos={k} includeEdit
190-
onKudosAction={loadSentKudos}/>
189+
onKudosAction={loadAndSetSentKudos}/>
191190
))}
192191
</div>
193192
) : (

0 commit comments

Comments
 (0)