Skip to content

Commit cbe1f57

Browse files
committed
Removed the workaround for dealing with default review assignments overwriting chosen review assignments.
1 parent 99af92b commit cbe1f57

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

web-ui/src/components/reviews/TeamReviews.jsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,6 @@ const TeamReviews = ({ onBack, periodId }) => {
204204
};
205205

206206
const loadTeamMembers = () => {
207-
// If we already have a list of team members, we should not overwrite the
208-
// list with the original list of team members.
209-
if (teamMembers.length > 0) {
210-
return;
211-
}
212-
213207
let source;
214208
if (!approvalMode || (isAdmin && showAll)) {
215209
source = currentMembers;
@@ -224,7 +218,7 @@ const TeamReviews = ({ onBack, periodId }) => {
224218
// Always filter the members down to existing selected assignments.
225219
// We do not want to add members that were not already selected.
226220
const memberIds = assignments.map(a => a.revieweeId);
227-
let members = source.filter(m => memberIds.includes(m.id));
221+
const members = source.filter(m => memberIds.includes(m.id));
228222
setTeamMembers(members);
229223
};
230224

0 commit comments

Comments
 (0)