Skip to content

Commit d177c08

Browse files
committed
Corrected parameter passed to sendEmail().
1 parent 4432171 commit d177c08

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

server/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -453,19 +453,20 @@ void sendSelfReviewEmail(UUID reviewPeriodId, SelfReviewDate date) {
453453

454454
List<String> addresses = recipients.stream()
455455
.map(p -> p.getWorkEmail()).toList();
456-
457-
// Customize the email content using the template.
458-
String content = String.format(template,
459-
webAddress,
460-
reviewPeriodId.toString(),
461-
dateAsString(reviewPeriod.get()
462-
.getSelfReviewCloseDate()),
463-
webAddress);
464-
465-
// Send out the email to everyone.
466-
emailSender.sendEmail(null, null, subject, content,
467-
recipients.toArray(
468-
new String[recipients.size()]));
456+
if (!addresses.isEmpty()) {
457+
// Customize the email content using the template.
458+
String content = String.format(
459+
template, webAddress,
460+
reviewPeriodId.toString(),
461+
dateAsString(reviewPeriod.get()
462+
.getSelfReviewCloseDate()),
463+
webAddress);
464+
465+
// Send out the email to everyone.
466+
emailSender.sendEmail(null, null, subject, content,
467+
addresses.toArray(
468+
new String[addresses.size()]));
469+
}
469470
} catch(Exception ex) {
470471
LOG.error("Send Self-Review Email: " + ex.toString());
471472
}

0 commit comments

Comments
 (0)