Skip to content

Commit d44681e

Browse files
committed
Updated to provide the "active" flag for guilds.
1 parent 4aed8c9 commit d44681e

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

server/src/test/java/com/objectcomputing/checkins/services/fixture/GuildFixture.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,27 @@ public interface GuildFixture extends MemberProfileFixture, RepositoryFixture{
1212
String COMPASS_ADDRESS = "https://www.compass.objectcomputing.com/";
1313

1414
default Guild createDefaultGuild() {
15-
return getGuildRepository().save(new Guild(UUID.randomUUID(), "Ninja", "Warriors", COMPASS_ADDRESS+"ninja_warriors/", false));
15+
return getGuildRepository().save(new Guild(UUID.randomUUID(), "Ninja", "Warriors", COMPASS_ADDRESS+"ninja_warriors/", false, true));
1616
}
1717

1818
default Guild createAnotherDefaultGuild() {
19-
return getGuildRepository().save(new Guild(UUID.randomUUID(), "Coding", "Warriors", COMPASS_ADDRESS+"coding_warriors/", false));
19+
return getGuildRepository().save(new Guild(UUID.randomUUID(), "Coding", "Warriors", COMPASS_ADDRESS+"coding_warriors/", false, true));
2020
}
2121

2222
default GuildCreateDTO createFromEntity(Guild entity) {
23-
return new GuildCreateDTO(entity.getName(), entity.getDescription(), entity.getLink(), false);
23+
return new GuildCreateDTO(entity.getName(), entity.getDescription(), entity.getLink(), false, true);
2424
}
2525

2626
default GuildUpdateDTO updateFromEntity(Guild entity) {
27-
return new GuildUpdateDTO(entity.getId(), entity.getName(), entity.getDescription(),entity.getLink(), entity.isCommunity());
27+
return new GuildUpdateDTO(entity.getId(), entity.getName(), entity.getDescription(),entity.getLink(), entity.isCommunity(), entity.isActive());
2828
}
2929

3030
default GuildResponseDTO responseFromEntity(Guild entity) {
31-
return new GuildResponseDTO(entity.getId(), entity.getName(), entity.getDescription(),entity.getLink(), entity.isCommunity());
31+
return new GuildResponseDTO(entity.getId(), entity.getName(), entity.getDescription(),entity.getLink(), entity.isCommunity(), entity.isActive());
3232
}
3333

3434
default Guild entityFromDTO(GuildUpdateDTO dto) {
35-
return new Guild(dto.getId(), dto.getName(), dto.getDescription(),dto.getLink(), dto.isCommunity());
35+
return new Guild(dto.getId(), dto.getName(), dto.getDescription(),dto.getLink(), dto.isCommunity(), dto.isActive());
3636
}
3737

3838
}

server/src/test/java/com/objectcomputing/checkins/services/guild/GuildControllerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ void testUpdateGuildWithExistingMembers() {
399399
void testUpdateGuildNullName() {
400400
Guild guildEntity = createDefaultGuild();
401401

402-
GuildUpdateDTO requestBody = new GuildUpdateDTO(guildEntity.getId(), null, null, null, false);
402+
GuildUpdateDTO requestBody = new GuildUpdateDTO(guildEntity.getId(), null, null, null, false, true);
403403
requestBody.setGuildMembers(new ArrayList<>());
404404

405405
final HttpRequest<GuildUpdateDTO> request = HttpRequest.PUT("", requestBody)
@@ -434,7 +434,7 @@ void testUpdateGuildNotExist() {
434434
Guild guildEntity = createDefaultGuild();
435435
UUID requestId = UUID.randomUUID();
436436
GuildUpdateDTO requestBody = new GuildUpdateDTO(requestId.toString(), guildEntity.getName(),
437-
guildEntity.getDescription(), guildEntity.getLink(), guildEntity.isCommunity());
437+
guildEntity.getDescription(), guildEntity.getLink(), guildEntity.isCommunity(), guildEntity.isActive());
438438
requestBody.setGuildMembers(new ArrayList<>());
439439

440440
MemberProfile memberProfileOfAdmin = createAnUnrelatedUser();

server/src/test/java/com/objectcomputing/checkins/services/guild/GuildTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void setUp() {
101101
void testGuildInstantiation() {
102102
final String name = "name";
103103
final String description = "description";
104-
Guild guild = new Guild(name, description, null, false);
104+
Guild guild = new Guild(name, description, null, false, true);
105105
assertEquals(guild.getName(), name);
106106
assertEquals(guild.getDescription(), description);
107107
}
@@ -112,7 +112,7 @@ void testGuildInstantiation2() {
112112
final String name = "name";
113113
final String description = "description";
114114
final String link = "https://www.compass.objectcomputing.com/guilds/name";
115-
Guild guild = new Guild(id, name, description, link, false);
115+
Guild guild = new Guild(id, name, description, link, false, true);
116116
assertEquals(guild.getId(), id);
117117
assertEquals(guild.getName(), name);
118118
assertEquals(guild.getDescription(), description);
@@ -126,7 +126,7 @@ void testConstraintViolation() {
126126
final UUID id = UUID.randomUUID();
127127
final String name = "name";
128128
final String description = "description";
129-
Guild guild = new Guild(id, name, description, null, false);
129+
Guild guild = new Guild(id, name, description, null, false, true);
130130

131131
guild.setName("");
132132

@@ -143,8 +143,8 @@ void testEquals() {
143143
final String name = "name";
144144
final String description = "description";
145145
final String link = "https://www.compass.objectcomputing.com/guilds/name";
146-
Guild g = new Guild(id, name, description, link, false);
147-
Guild g2 = new Guild(id, name, description, link, false);
146+
Guild g = new Guild(id, name, description, link, false, true);
147+
Guild g2 = new Guild(id, name, description, link, false, true);
148148

149149
assertEquals(g, g2);
150150

@@ -160,7 +160,7 @@ void testHash() {
160160
final String name = "name";
161161
final String description = "description";
162162
final String link = "https://www.compass.objectcomputing.com/guilds/name";
163-
Guild g = new Guild(id, name, description, link, false);
163+
Guild g = new Guild(id, name, description, link, false, true);
164164

165165
map.put(g, true);
166166

@@ -174,7 +174,7 @@ void testToString() {
174174
final String description = "description------description";
175175
final String link = "https://www.compass.objectcomputing.com/guilds/name";
176176
final String isCommunity = "false";
177-
Guild g = new Guild(id, name, description,link, false);
177+
Guild g = new Guild(id, name, description,link, false, true);
178178

179179
String s = g.toString();
180180
assertTrue(s.contains(name));
@@ -261,7 +261,7 @@ void testSaveGuildWithValidData() {
261261
MemberProfile memberProfile = new MemberProfile();
262262
memberProfile.setWorkEmail("[email protected]");
263263

264-
Guild guild = new Guild(UUID.randomUUID(), "test", "example", link, true);
264+
Guild guild = new Guild(UUID.randomUUID(), "test", "example", link, true, true);
265265
when(guildsRepo.search(any(), any())).thenReturn(Collections.emptyList());
266266
when(guildsRepo.save(any())).thenReturn(guild);
267267
when(memberProfileServices.getById(any())).thenReturn(memberProfile);

0 commit comments

Comments
 (0)