Skip to content

Commit d9186fe

Browse files
authored
Merge pull request #2703 from objectcomputing/release/0.8
Deploye v0.8.1 to production
2 parents fde6ff3 + 1470bbb commit d9186fe

File tree

8 files changed

+49
-14
lines changed

8 files changed

+49
-14
lines changed

server/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ plugins {
77
id "jacoco"
88
}
99

10-
version "0.8.0"
10+
version "0.8.1"
1111
group "com.objectcomputing.checkins"
1212

1313
repositories {

server/src/main/java/com/objectcomputing/checkins/services/role/member_roles/MemberRoleController.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import io.micronaut.scheduling.annotation.ExecuteOn;
77
import io.micronaut.security.annotation.Secured;
88
import io.micronaut.security.rules.SecurityRule;
9+
import io.micronaut.cache.annotation.CacheInvalidate;
910
import jakarta.validation.constraints.NotNull;
1011

1112
import java.util.List;
@@ -34,6 +35,7 @@ HttpResponse<?> deleteMemberRole(@NotNull UUID roleId, @NotNull UUID memberId){
3435
}
3536

3637
@Post
38+
@CacheInvalidate(cacheNames = {"role-permission-cache"})
3739
HttpResponse<MemberRole> saveMemberRole(@NotNull @Body MemberRoleId id){
3840
MemberRole memberRole = memberRoleServices.saveByIds(id.getMemberId(), id.getRoleId());
3941
return HttpResponse.ok(memberRole);

web-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "web-ui",
3-
"version": "0.8.0",
3+
"version": "0.8.1",
44
"private": true,
55
"type": "module",
66
"dependencies": {

web-ui/src/components/settings/types/boolean.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const SettingsBoolean = ({ name, description, value, handleChange }) => {
2626
</label>
2727
{description && <p>{description}</p>}
2828
<Switch
29+
disableRipple
2930
id={labelId}
3031
className="settings-control"
3132
type="checkbox"

web-ui/src/pages/AnniversaryReportPage.jsx

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
noPermission,
1919
} from '../context/selectors';
2020
import { useQueryParameters } from '../helpers/query-parameters';
21+
import SkeletonLoader from '../components/skeleton_loader/SkeletonLoader';
2122

2223
const months = [
2324
'January',
@@ -43,6 +44,7 @@ const AnniversaryReportPage = () => {
4344
const [searchAnniversaryResults, setSearchAnniversaryResults] = useState([]);
4445
const [selectedMonths, setSelectedMonths] = useState(defaultMonths);
4546
const [hasSearched, setHasSearched] = useState(false);
47+
const [loading, setLoading] = useState(false);
4648

4749
useQueryParameters([
4850
{
@@ -57,9 +59,22 @@ const AnniversaryReportPage = () => {
5759
]);
5860

5961
const handleSearch = async monthsToSearch => {
60-
const anniversaryResults = await getAnniversaries(monthsToSearch, csrf);
61-
setSearchAnniversaryResults(sortAnniversaries(anniversaryResults));
62-
setHasSearched(true);
62+
setLoading(true);
63+
try {
64+
const anniversaryResults = await getAnniversaries(monthsToSearch, csrf);
65+
setSearchAnniversaryResults(sortAnniversaries(anniversaryResults));
66+
setHasSearched(true);
67+
} catch(e) {
68+
console.error(e);
69+
window.snackDispatch({
70+
type: UPDATE_TOAST,
71+
payload: {
72+
severity: 'error',
73+
toast: e,
74+
}
75+
});
76+
}
77+
setLoading(false);
6378
};
6479

6580
function onMonthChange(event, newValue) {
@@ -111,6 +126,10 @@ const AnniversaryReportPage = () => {
111126
</div>
112127
<div>
113128
{
129+
loading ?
130+
Array.from({ length: 10 }).map((_, index) => (
131+
<SkeletonLoader key={index} type="feedback_requests" />
132+
)) :
114133
<div className="search-results">
115134
<SearchBirthdayAnniversaryResults
116135
hasSearched={hasSearched}

web-ui/src/pages/BirthdayReportPage.jsx

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { getBirthdays } from '../api/birthdayanniversary';
1111
import { UPDATE_TOAST } from '../context/actions';
1212
import SearchBirthdayAnniversaryResults from '../components/search-results/SearchBirthdayAnniversaryResults';
1313
import { sortBirthdays } from '../context/util';
14+
import SkeletonLoader from '../components/skeleton_loader/SkeletonLoader';
1415

1516
import {
1617
selectCsrfToken,
@@ -43,6 +44,7 @@ const BirthdayReportPage = () => {
4344
const [searchBirthdayResults, setSearchBirthdayResults] = useState([]);
4445
const [selectedMonths, setSelectedMonths] = useState(defaultMonths);
4546
const [hasSearched, setHasSearched] = useState(false);
47+
const [loading, setLoading] = useState(false);
4648

4749
useQueryParameters([
4850
{
@@ -57,9 +59,21 @@ const BirthdayReportPage = () => {
5759
]);
5860

5961
const handleSearch = async monthsToSearch => {
60-
const birthdayResults = await getBirthdays(monthsToSearch, csrf);
61-
setSearchBirthdayResults(sortBirthdays(birthdayResults));
62-
setHasSearched(true);
62+
setLoading(true);
63+
try {
64+
const birthdayResults = await getBirthdays(monthsToSearch, csrf);
65+
setSearchBirthdayResults(sortBirthdays(birthdayResults));
66+
setHasSearched(true);
67+
} catch(e) {
68+
window.snackDispatch({
69+
type: UPDATE_TOAST,
70+
payload: {
71+
severity: 'error',
72+
toast: e,
73+
}
74+
});
75+
}
76+
setLoading(false);
6377
};
6478

6579
function onMonthChange(event, newValue) {
@@ -111,6 +125,10 @@ const BirthdayReportPage = () => {
111125
</div>
112126
<div>
113127
{
128+
loading ?
129+
Array.from({ length: 10 }).map((_, index) => (
130+
<SkeletonLoader key={index} type="feedback_requests" />
131+
)) :
114132
<div className="search-results">
115133
<SearchBirthdayAnniversaryResults
116134
hasSearched={hasSearched}

web-ui/src/pages/SettingsPage.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ const SettingsPage = () => {
214214
selectHasAdministerSettingsPermission(state) &&
215215
<div className="buttons">
216216
<Button
217+
disableRipple
217218
color="primary"
218219
onClick={save}>
219220
Save

web-ui/src/pages/__snapshots__/SettingsPage.test.jsx.snap

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ exports[`SettingsPage > renders correctly 1`] = `
4848
<span
4949
class="MuiSwitch-thumb css-jsexje-MuiSwitch-thumb"
5050
/>
51-
<span
52-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
53-
/>
5451
</span>
5552
<span
5653
class="MuiSwitch-track css-1yjjitx-MuiSwitch-track"
@@ -125,9 +122,6 @@ exports[`SettingsPage > renders correctly 1`] = `
125122
type="button"
126123
>
127124
Save
128-
<span
129-
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
130-
/>
131125
</button>
132126
</div>
133127
</div>

0 commit comments

Comments
 (0)