Skip to content

Commit dafe0f3

Browse files
committed
Fixed edge case w/ recipient filter + UI upgrades
1 parent 7e9d353 commit dafe0f3

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

web-ui/src/components/view_feedback_responses/ViewFeedbackResponses.jsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,19 @@ const ViewFeedbackResponses = () => {
157157

158158
useEffect(() => {
159159
let responsesToDisplay = [...questionsAndAnswers];
160-
160+
// Filter based on selected responders
161161
responsesToDisplay = responsesToDisplay.map(response => {
162162
let filteredAnswers = response.answers.filter(answer =>
163163
selectedResponders.includes(answer.responder)
164164
);
165+
166+
// If no filtered answers remain after filtering recipients, display a unified error message
167+
if (filteredAnswers.length === 0) {
168+
filteredAnswers = [{ answer: 'No input due to recipient filter', responder: null }];
169+
}
170+
165171
if (searchText.trim()) {
172+
// Filter based on search text
166173
filteredAnswers = filteredAnswers.filter(
167174
({ answer }) =>
168175
answer &&

web-ui/src/components/view_feedback_responses/feedback_response_card/FeedbackResponseCard.jsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ const FeedbackResponseCard = props => {
2323

2424
// Handle different input types and answer values
2525
const getFormattedAnswer = () => {
26+
if (props.answer === 'No input due to recipient filter') {
27+
return props.answer;
28+
}
29+
2630
if (props.inputType === 'NONE') {
2731
return 'No input'; // Display "No input" if the question input type is "NONE"
2832
}

0 commit comments

Comments
 (0)