Fix some g++ 4.8 warning messages.

Author: Huang-Ming Huang

src/fast_type_gen/fast_type_gen.cpp

@@ -39,7 +39,7 @@ bool check_long_option(const std::string &command, int argc, const char **argv,
   }
 }
 
-bool check_short_option(const std::string &command, int argc, const char **argv, int &i, const char *&arg, char flag, const char *&output, bool bad)
+bool check_short_option(const std::string &command, int argc, const char **argv, int &i, const char *&arg, char flag, const char *&output, bool &bad)
 {
   if (*arg == flag) {
     if (*++arg != '\0') {

src/mfast/decimal_ref.h

@@ -262,7 +262,7 @@ class decimal_mref : public make_field_mref<decimal_cref> {
                instruction_cptr instruction)
       : base_type(alloc, storage, instruction) {}
 
-  decimal_mref(const decimal_mref &other) = default;
+  decimal_mref(const decimal_mref &) = default;
 
   explicit decimal_mref(const field_mref_base &other) : base_type(other) {}
   int64_t mantissa() const { return this->storage()->of_decimal.mantissa_; }

src/mfast/enum_ref.h

@@ -68,7 +68,7 @@ class enum_mref : public make_field_mref<enum_cref> {
             instruction_cptr instruction)
       : base_type(alloc, storage, instruction) {}
 
-  enum_mref(const enum_mref &other) = default;
+  enum_mref(const enum_mref &) = default;
 
   void as(const enum_cref &cref) const {
     if (cref.absent()) {

src/mfast/int_ref.h

@@ -82,7 +82,7 @@ template <typename T> class int_mref : public make_field_mref<int_cref<T>> {
            instruction_cptr instruction)
       : base_type(alloc, storage, instruction) {}
 
-  int_mref(const int_mref &other) = default;
+  int_mref(const int_mref &) = default;
 
   explicit int_mref(const field_mref_base &other) : base_type(other) {}
   void as(const int_cref<T> &cref) const {

src/mfast/sequence_ref.h

@@ -23,7 +23,7 @@ class sequence_element_cref : public aggregate_cref {
   sequence_element_cref(const value_storage *storage,
                         instruction_cptr instruction);
 
-  sequence_element_cref(const sequence_element_cref &other) = default;
+  sequence_element_cref(const sequence_element_cref &) = default;
   instruction_cptr instruction() const;
 
   bool element_unnamed() const {

src/mfast/string_ref.h

@@ -190,7 +190,7 @@ template <> class vector_mref<char> : public string_mref_base<char> {
               instruction_cptr instruction)
       : base_type(alloc, storage, instruction) {}
 
-  vector_mref(const vector_mref<char> &other) = default;
+  vector_mref(const vector_mref<char> &) = default;
 
   explicit vector_mref(const field_mref_base &other) : base_type(other) {}
   vector_mref &operator=(const boost::string_ref &s) {

src/mfast/vector_ref.h

@@ -175,7 +175,7 @@ class vector_mref_base : public make_field_mref<vector_cref<T>> {
                    instruction_cptr instruction)
       : base_type(alloc, storage, instruction) {}
 
-  vector_mref_base(const vector_mref_base &other) = default;
+  vector_mref_base(const vector_mref_base &) = default;
 
   explicit vector_mref_base(const field_mref_base &other) : base_type(other) {}
   void to_initial_value() const {

tests/int_vector_test.cpp

@@ -52,23 +52,23 @@ void test_int_vector()
                                    "int_vector","");
 
   inst.construct_value(storage, &alloc);
-  REQUIRE(storage.of_array.capacity_in_bytes_ ==  0UL);
-  REQUIRE(storage.is_defined() ==                 true);
+  REQUIRE((storage.of_array.capacity_in_bytes_ ==  0UL));
+  REQUIRE((storage.is_defined() ==                 true));
 
   vector_mref<T> mref(&alloc, &storage, &inst);
 
-  REQUIRE(mref.size() ==  0UL);
+  REQUIRE((mref.size() ==  0UL));
 
   const unsigned SIZE=100;
   int array[SIZE];
   std::generate(array, array+SIZE, c_unique());
 
   mref.assign(array, array+SIZE);
 
-  REQUIRE(mref.size() ==  SIZE);
+  REQUIRE((mref.size() ==  SIZE));
 
   for (unsigned i = 0; i < SIZE; ++i) {
-    REQUIRE(mref[i] ==  static_cast<T>(i+1));
+    REQUIRE((mref[i] ==  static_cast<T>(i+1)));
   }
 
   inst.destruct_value(storage, &alloc);