fix: parse-version exists func to minimize return statements

in order to address the code review comments

Author: Vladislav Yevtushenko

src/parser-version.js

@@ -32,18 +32,21 @@ const request = require('sync-request'),
      * @return {Boolean} True if version exists, false otherwise
      */
     exists(ver) {
-      if (!ver || ver === 'undefined') {
-        return false;
-      }
-      try {
-        const repo = 'org/eolang/eo-maven-plugin',
-          artifactId = 'eo-maven-plugin',
-          url = `https://repo.maven.apache.org/maven2/${repo}/${ver}/${artifactId}-${ver}.pom`,
-          res = request('GET', url, {timeout: 10000, socketTimeout: 10000});
-        return res.statusCode === 200;
-      } catch (e) {
-        console.debug('Unable to validate parser version (network error): %s', e.message);
-        return true;
+      let result;
+      if (ver && ver !== 'undefined') {
+        try {
+          const repo = 'org/eolang/eo-maven-plugin',
+            artifactId = 'eo-maven-plugin',
+            url = `https://repo.maven.apache.org/maven2/${repo}/${ver}/${artifactId}-${ver}.pom`,
+            res = request('GET', url, {timeout: 10000, socketTimeout: 10000});
+          result = res.statusCode === 200;
+        } catch (e) {
+          console.debug('Unable to validate parser version (network error): %s', e.message);
+          result = false;
+        }
+      } else {
+        result = false;
       }
+      return result;
     }
   };

test/commands/test_parse.js

@@ -6,7 +6,6 @@
 const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
-const {execSync} = require('child_process');
 const {runSync, assertFilesExist, parserVersion, homeTag, weAreOnline} = require('../helpers');
 
 describe('parse', () => {
@@ -21,26 +20,6 @@ describe('parse', () => {
     );
   };
 
-  const runCommand = (args) => {
-    try {
-      return execSync(
-        `node ${path.resolve('./src/eoc.js')} --batch ${args}`,
-        {
-          timeout: 30000,
-          windowsHide: true,
-          encoding: 'utf8'
-        }
-      );
-    } catch (ex) {
-      return {
-        stdout: ex.stdout ? ex.stdout.toString() : '',
-        stderr: ex.stderr ? ex.stderr.toString() : '',
-        error: ex.message,
-        status: ex.status
-      };
-    }
-  };
-
   it('parses a simple .EO program', (done) => {
     const home = path.resolve('temp/test-parse/simple');
     createTestProject(home);
@@ -67,79 +46,79 @@ describe('parse', () => {
     this.timeout(30000);
     const home = path.resolve('temp/test-parse/invalid-version');
     createTestProject(home);
-
-    const result = runCommand([
-      'parse',
-      '--parser=999.999.999',
-      '-s', path.resolve(home, 'src'),
-      '-t', path.resolve(home, 'target'),
-    ].join(' '));
-
-    assert(result.status !== 0, 'Command should fail with non-zero exit code');
+    assert.throws(
+      () => {
+        runSync([
+          'parse',
+          '--parser=999.999.999',
+          '-s', path.resolve(home, 'src'),
+          '-t', path.resolve(home, 'target'),
+        ]);
+      },
+      'Command should fail with invalid parser version'
+    );
   });
 
   it('accepts valid parser version', function () {
     this.timeout(60000);
     const home = path.resolve('temp/test-parse/valid-version');
     createTestProject(home);
-
-    const result = runCommand([
+    runSync([
       'parse',
       '--parser=0.28.11',
       '-s', path.resolve(home, 'src'),
       '-t', path.resolve(home, 'target'),
-    ].join(' '));
-
-    if (typeof result === 'object' && result.status !== undefined) {
-      assert(
-        result.status === 0,
-        'Command should succeed with valid parser version'
-      );
-    }
+    ]);
   });
 
   it('validates parser version before calling Maven', function () {
     this.timeout(30000);
     const home = path.resolve('temp/test-parse/early-validation');
     createTestProject(home);
-
-    const result = runCommand([
-      'parse',
-      '--parser=999.999.999',
-      '-s', path.resolve(home, 'src'),
-      '-t', path.resolve(home, 'target'),
-    ].join(' '));
-
-    assert(result.status !== 0, 'Command should fail with invalid version');
+    assert.throws(
+      () => {
+        runSync([
+          'parse',
+          '--parser=999.999.999',
+          '-s', path.resolve(home, 'src'),
+          '-t', path.resolve(home, 'target'),
+        ]);
+      },
+      'Command should fail with invalid version'
+    );
   });
 
   it('handles assemble command with invalid version', function () {
     this.timeout(30000);
     const home = path.resolve('temp/test-parse/assemble-invalid');
     createTestProject(home);
-
-    const result = runCommand([
-      'assemble',
-      '--parser=999.999.999',
-      '-s', path.resolve(home, 'src'),
-      '-t', path.resolve(home, 'target'),
-    ].join(' '));
-
-    assert(result.status !== 0, 'Assemble should fail with invalid version');
+    assert.throws(
+      () => {
+        runSync([
+          'assemble',
+          '--parser=999.999.999',
+          '-s', path.resolve(home, 'src'),
+          '-t', path.resolve(home, 'target'),
+        ]);
+      },
+      'Assemble should fail with invalid version'
+    );
   });
 
   it('handles lint command with invalid version', function () {
     this.timeout(30000);
     const home = path.resolve('temp/test-parse/lint-invalid');
     createTestProject(home);
-
-    const result = runCommand([
-      'lint',
-      '--parser=999.999.999',
-      '-s', path.resolve(home, 'src'),
-      '-t', path.resolve(home, 'target'),
-    ].join(' '));
-
-    assert(result.status !== 0, 'Lint should fail with invalid version');
+    assert.throws(
+      () => {
+        runSync([
+          'lint',
+          '--parser=999.999.999',
+          '-s', path.resolve(home, 'src'),
+          '-t', path.resolve(home, 'target'),
+        ]);
+      },
+      'Lint should fail with invalid version'
+    );
   });
 });