bug(#632): wrong-test-order lint (#784)

* bug(#632): add wrong-test-order lint to enforce proper test placement in EO code

* bug(#632): motive

* bug(#632): disable depends on RUN_WORKFLOW

* bug(#632): disable depends on RUN_WORKFLOW

* ci: update java versions in maven workflow matrix and add exclusions

* ci: remove extra spaces in java version matrix for consistency

* ci: replace env with vars in workflow conditionals to use repository variables

* empty commit to restart pipelines

* ci: add cleanup step to remove eolang dependencies before maven build

* ci: increase deep workflow timeout from 20 to 30 minutes

* empty commit to restart pipelines

Author: h1alexbel

.github/workflows/deep.yml

@@ -12,7 +12,7 @@ name: deep
       - master
 jobs:
   deep:
-    timeout-minutes: 20
+    timeout-minutes: 30
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v5

.github/workflows/hone.yml

@@ -10,6 +10,8 @@ name: hone
   pull_request:
     branches:
       - master
+env:
+  RUN_WORKFLOW: false
 jobs:
   hone:
     timeout-minutes: 45
@@ -19,7 +21,7 @@ jobs:
     #  this issue: https://github.com/objectionary/hone-maven-plugin/issues/297. Also, the plugin run
     #  is time-consuming, we should enable it only after the plugin will have stable execution time,
     #  in order to not disturb the development in this repository.
-    if: false
+    if: ${{ vars.RUN_WORKFLOW == 'true' }}
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-java@v5

.github/workflows/jmh.yml

@@ -7,11 +7,13 @@ name: jmh
   pull_request:
     branches:
       - master
+env:
+  RUN_WORKFLOW: false
 jobs:
   jmh:
     timeout-minutes: 45
     runs-on: ubuntu-24.04
-    if: false
+    if: ${{ vars.RUN_WORKFLOW == 'true' }}
     steps:
       - name: Run JMH Benchmark Action
         uses: volodya-lombrozo/jmh-benchmark-action@v1

.github/workflows/mvn.yml

@@ -16,7 +16,12 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-24.04, windows-2022, macos-15]
-        java: [11, 21]
+        java: [17, 23]
+        exclude:
+          - os: windows-2022
+            java: 17
+          - os: macos-15
+            java: 17
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v5
@@ -29,5 +34,8 @@ jobs:
           path: ~/.m2/repository
           key: ${{ runner.os }}-jdk-${{ matrix.java }}-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: ${{ runner.os }}-jdk-${{ matrix.java }}-maven-
+      - uses: JesseTG/[email protected]
+        with:
+          path: ~/.m2/repository/org/eolang
       - run: mvn clean install -PskipITs --errors --batch-mode
       - run: mvn test --errors --batch-mode

src/main/resources/org/eolang/lints/tests/wrong-test-order.xsl

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ * SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+ * SPDX-License-Identifier: MIT
+-->
+<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:eo="https://www.eolang.org" id="wrong-test-order" version="2.0">
+  <xsl:import href="/org/eolang/parser/_funcs.xsl"/>
+  <xsl:import href="/org/eolang/funcs/lineno.xsl"/>
+  <xsl:import href="/org/eolang/funcs/escape.xsl"/>
+  <xsl:import href="/org/eolang/funcs/defect-context.xsl"/>
+  <xsl:output encoding="UTF-8" method="xml"/>
+  <xsl:template match="/">
+    <defects>
+      <xsl:for-each select="/object//o[starts-with(@name, '+')]">
+        <xsl:variable name="next" select="following-sibling::*[1]"/>
+        <xsl:if test="$next[self::o] and not(starts-with($next/@name, '+'))">
+          <xsl:element name="defect">
+            <xsl:variable name="line" select="eo:lineno(@line)"/>
+            <xsl:attribute name="line">
+              <xsl:value-of select="$line"/>
+            </xsl:attribute>
+            <xsl:if test="$line = '0'">
+              <xsl:attribute name="context">
+                <xsl:value-of select="eo:defect-context(.)"/>
+              </xsl:attribute>
+            </xsl:if>
+            <xsl:attribute name="severity">
+              <xsl:text>warning</xsl:text>
+            </xsl:attribute>
+            <xsl:text>The unit test wrongly ordered: </xsl:text>
+            <xsl:value-of select="eo:escape(eo:escape-plus(@name))"/>
+          </xsl:element>
+        </xsl:if>
+      </xsl:for-each>
+    </defects>
+  </xsl:template>
+</xsl:stylesheet>

src/main/resources/org/eolang/motives/tests/wrong-test-order.md

@@ -0,0 +1,19 @@
+# Wrong test order
+
+Unit tests must be located after live objects:
+
+Incorrect:
+
+```eo
+[] > foo
+  [] +> runs-something
+  [] > bar
+```
+
+Correct:
+
+```eo
+[] > foo
+  [] > bar
+  [] +> runs-something
+```

src/test/resources/org/eolang/lints/packs/single/wrong-test-order/allows-correct-order.yaml

@@ -0,0 +1,13 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+sheets:
+  - /org/eolang/lints/tests/wrong-test-order.xsl
+asserts:
+  - /defects[count(defect[@severity='warning'])=1]
+  - /defects/defect[@line='3']
+input: |
+  [] > foo
+    [] > bar
+    [] +> runs-program
+    [] > boom

src/test/resources/org/eolang/lints/packs/single/wrong-test-order/allows-no-tests.yaml

@@ -0,0 +1,12 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+sheets:
+  - /org/eolang/lints/tests/wrong-test-order.xsl
+asserts:
+  - /defects[count(defect[@severity='warning'])=0]
+input: |
+  [] > foo
+    [] > a
+    [] > x
+    [] > y

src/test/resources/org/eolang/lints/packs/single/wrong-test-order/allows-single-test.yaml

@@ -0,0 +1,10 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+sheets:
+  - /org/eolang/lints/tests/wrong-test-order.xsl
+asserts:
+  - /defects[count(defect[@severity='warning'])=0]
+input: |
+  [] > main
+    [] +> testing

src/test/resources/org/eolang/lints/packs/single/wrong-test-order/allows-tests-only.yaml

@@ -0,0 +1,11 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+sheets:
+  - /org/eolang/lints/tests/wrong-test-order.xsl
+asserts:
+  - /defects[count(defect[@severity='warning'])=0]
+input: |
+  [] > at
+    [] +> test
+    [] +> another-test