Merge pull request #633 from h1alexbel/624

bug(#624): `LtInconsistentArgs` understands anonymous objects in path

Author: yegor256

src/main/java/org/eolang/lints/LtInconsistentArgs.java

@@ -279,7 +279,7 @@ private static String voidFqn(final String base, final Xnav object) {
             LtInconsistentArgs.parentTree(
                 method
             ),
-            method.attribute("name").text().get(),
+            LtInconsistentArgs.coordinates(method),
             base
         );
     }
@@ -293,7 +293,7 @@ private static String parentTree(final Xnav object) {
         final List<String> tree = new ListOf<>();
         Xnav current = LtInconsistentArgs.parentObject(object);
         while (!"object".equals(current.node().getNodeName())) {
-            tree.add(current.attribute("name").text().get());
+            tree.add(LtInconsistentArgs.coordinates(current));
             current = LtInconsistentArgs.parentObject(current);
         }
         final String result;
@@ -346,6 +346,21 @@ private static String relativizeToTopObject(final String base, final Xnav source
         return result;
     }
 
+    /**
+     * Object coordinates.
+     * @param object Object
+     * @return Object coordinates
+     */
+    private static String coordinates(final Xnav object) {
+        final String result;
+        if (object.attribute("name").text().isPresent()) {
+            result = object.attribute("name").text().get();
+        } else {
+            result = ":anonymous";
+        }
+        return result;
+    }
+
     /**
      * Parent of the given object.
      * @param object Current object

src/main/java/org/eolang/lints/VoidXpath.java

@@ -42,6 +42,6 @@ public String asString() {
             IntStream.range(rstart + 1, normalized.size())
                 .mapToObj(normalized::get)
                 .collect(Collectors.joining(".", "$.", ""))
-        );
+        ).replace("[@name=':anonymous']", "");
     }
 }

src/test/java/org/eolang/lints/VoidXpathTest.java

@@ -20,7 +20,8 @@ final class VoidXpathTest {
     @CsvSource(
         {
             "main.$.x.∅, //o[@name='main']/o[@base='$.x']",
-            "foo.foo.foo.$.x.∅, //o[@name='foo']/o[@name='foo']/o[@name='foo']/o[@base='$.x']"
+            "foo.foo.foo.$.x.∅, //o[@name='foo']/o[@name='foo']/o[@name='foo']/o[@base='$.x']",
+            "@.foo.:anonymous.$.x.∅, //o[@name='@']/o[@name='foo']/o/o[@base='$.x']"
         }
     )
     void convertsToXpath(final String fqn, final String xpath) {

src/test/java/org/eolang/lints/WpaStory.java

@@ -17,6 +17,7 @@
 import org.cactoos.map.MapEntry;
 import org.cactoos.map.MapOf;
 import org.eolang.parser.EoSyntax;
+import org.junit.jupiter.api.Assumptions;
 import org.xembly.Directives;
 import org.xembly.ImpossibleModificationException;
 import org.xembly.Xembler;
@@ -58,6 +59,7 @@ final class WpaStory {
     @SuppressWarnings("unchecked")
     public Map<List<String>, Map<XML, Map<String, XML>>> execute() throws IOException {
         final Map<String, Object> loaded = new Yaml().load(this.yaml);
+        Assumptions.assumeTrue(loaded.get("skip") == null);
         final Map<String, XML> programs = new HashMap<>(0);
         loaded.forEach(
             (key, val) -> {

src/test/resources/org/eolang/lints/packs/wpa/inconsistent-args/catches-inconsistency-in-nested-anonymous-formations.yaml

@@ -0,0 +1,31 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+# yamllint disable rule:line-length
+# @todo #624:60min Enable `catches-inconsistency-in-nested-anonymous-formations` test story.
+#  For now, its disabled because `LtInconsistentArgs` fails to convert parent tree with anonymous
+#  objects to searchable XPath for the XMIR. We should change our logic in both
+#  `LtInconsistentArgs#voidFqn()` and `VoidXpath`. Don't forget to enable
+#  `catches-inconsistency-resolving-anonymous-path.yaml`,
+#  `catches-inconsistency-when-parent-object-lacks-name.yaml`, and test stories as well.
+skip: true
+lints:
+  - inconsistent-args
+asserts:
+  - /defects[count(defect[@severity='warning'])=2]
+  - /defects/defect[@line='9']
+  - /defects/defect[@line='10']
+  - /defects/defect[contains(normalize-space(), 'foo.@.:anonymous.@.:anonymous.@.:anonymous.$.x.∅')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:9]')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:10]')]
+foo.eo: |
+  # Foo.
+  [] > foo
+    start > @
+      []
+        i > @
+          []
+            i > @
+              [x]
+                x 0 > x1
+                x 0 1 > x2

src/test/resources/org/eolang/lints/packs/wpa/inconsistent-args/catches-inconsistency-inside-anonymous-with-void-from-top.yaml

@@ -0,0 +1,18 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+lints:
+  - inconsistent-args
+asserts:
+  - /defects[count(defect[@severity='warning'])=2]
+  - /defects/defect[@line='5']
+  - /defects/defect[@line='6']
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:5]')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:6]')]
+foo.eo: |
+  # Foo.
+  [x] > foo
+    start > @
+      []
+        x 0 > x1
+        x 0 1 > x2

src/test/resources/org/eolang/lints/packs/wpa/inconsistent-args/catches-inconsistency-resolving-anonymous-path.yaml

@@ -0,0 +1,22 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+skip: true
+lints:
+  - inconsistent-args
+asserts:
+  - /defects[count(defect[@severity='warning'])=2]
+  - /defects/defect[@line='7']
+  - /defects/defect[@line='8']
+  - /defects/defect[contains(normalize-space(), 'foo.@.:anonymous.$.x.∅')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:7]')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:8]')]
+foo.eo: |
+  # Foo.
+  [x] > foo
+    x 0 > x1
+    x 1 > x2
+    start > @
+      [x]
+        $.x 0 > x1
+        $.x 0 1 > x2

src/test/resources/org/eolang/lints/packs/wpa/inconsistent-args/catches-inconsistency-when-parent-object-lacks-name.yaml

@@ -0,0 +1,19 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2025 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+skip: true
+lints:
+  - inconsistent-args
+asserts:
+  - /defects[count(defect[@severity='warning'])=2]
+  - /defects/defect[@line='5']
+  - /defects/defect[@line='6']
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:5]')]
+  - /defects/defect[contains(normalize-space(), 'clashes with [foo:6]')]
+foo.eo: |
+  # Foo.
+  [] > foo
+    start > @
+      [x]
+        x 0 > x1
+        x 0 1 > x2