improved output (when no API key), additional hashes for shell config files, etc...

Author: objective-see

AppDelegate.m

@@ -12,7 +12,7 @@
 //TODO: scan other volumes
 //TODO: support delete items
 //TODO: search in UI
-//TODO: auto-start if persisted
+
 
 /* GLOBALS */
 
@@ -940,7 +940,8 @@ -(void)displayScanStats
 
     //when VT integration is enabled
     // add flagged and unknown items
-    if(YES != self.prefsWindowController.disableVTQueries)
+    if( !self.prefsWindowController.disableVTQueries &&
+        self.prefsWindowController.vtAPIKey.length)
     {
         //when network is down
         // ->add msg about not being able to query VT

Localizable.xcstrings

@@ -682,6 +682,9 @@
         }
       }
     },
+    "VirusTotal Results: N/A (No API Key)" : {
+      "comment" : "VirusTotal Results: N/A (No API Key)"
+    },
     "VirusTotal:\r\n %lu flagged item(s)\r\n %lu unknown item(s)" : {
       "comment" : "VirusTotal:\r\n %lu flagged item(s)\r\n %lu unknown item(s)",
       "localizations" : {

Plugins/ShellConfigs.m

@@ -9,15 +9,14 @@
 #import "ShellConfigs.h"
 
 //plugin name
-#define PLUGIN_NAME @"Shell Config Files"
+#define PLUGIN_NAME @"Shell Configuration Files"
 
 //plugin description
 #define PLUGIN_DESCRIPTION NSLocalizedString(@"Commands executed at shell launch", @"Commands executed at shell launch")
 
 //plugin icon
 #define PLUGIN_ICON @"shellConfigIcon"
 
-
 @implementation ShellConfigs
 
 //init

PrefsWindowController.m

@@ -52,8 +52,6 @@ -(void)windowDidLoad
         self.showTrustedItemsBtn.state = NSControlStateValueOn;
     }
 
-    //TODO: add start at load
-    
     //check if 'show trusted items' button should be selected
     if(YES == self.startAtLogin)
     {
@@ -91,13 +89,12 @@ -(void)windowDidBecomeKey:(NSNotification *)notification {
 }
 
 
-//TODO: splash screen
 //register default prefs
 // only used if user hasn't set any
 -(void)registerDefaults
 {
     //set defaults
-    [[NSUserDefaults standardUserDefaults] registerDefaults:@{PREF_SHOW_TRUSTED_ITEMS:@NO, PREF_DISABLE_UPDATE_CHECK:@NO, PREF_DISABLE_VT_QUERIRES:@NO}];
+    [[NSUserDefaults standardUserDefaults] registerDefaults:@{PREF_SHOW_TRUSTED_ITEMS:@NO, PREF_START_AT_LOGIN:@NO, PREF_DISABLE_UPDATE_CHECK:@NO, PREF_DISABLE_VT_QUERIRES:@YES}];
 
     return;
 }

ResultsWindowController.m

@@ -56,11 +56,21 @@ -(void)windowDidLoad
     // disabled? something else?
     else
     {
+        //hide 'unknown items' button
+        self.submitToVT.hidden = YES;
+        
         //disabled
-        if(YES == ((AppDelegate*)[[NSApplication sharedApplication] delegate]).prefsWindowController.disableVTQueries)
+        if(((AppDelegate*)NSApplication.sharedApplication.delegate).prefsWindowController.disableVTQueries)
         {
             self.vtDetailsLabel.stringValue = NSLocalizedString(@"VirusTotal Results: N/A (Disabled)", @"VirusTotal Results: N/A (Disabled)");
         }
+        
+        //no API key
+        else if(!((AppDelegate*)NSApplication.sharedApplication.delegate).prefsWindowController.vtAPIKey.length)
+        {
+            self.vtDetailsLabel.stringValue = NSLocalizedString(@"VirusTotal Results: N/A (No API Key)", @"VirusTotal Results: N/A (No API Key)");
+        }
+        
         //?
         else
         {

WhiteList/whitelistedFiles.json

@@ -22,8 +22,8 @@
     "/etc/defaults/periodic.conf":["7beb8971f053949f6f1681a9d5204028", "62842e4978d878da44697ba81eac797c"],
     "/etc/rc.common":["5db454651210bcb920c010f8149d118c", "9c3ea0b6d054087fecd2013d875c336b", "28ce428faefe6168618867f3ff5527f9"],
     "/usr/libexec/tmp_cleaner":["33747b79a29e3462d1799c911854461c"],
-    "/etc/zprofile":["82e0d6b73125cdc9428e1f4a39d2a5a1"],
-    "/etc/zshrc":["8c234b3fb7e4a27f1364df17cb6b22c5"],
+    "/etc/zprofile":["179b0fd32c80f305c2b1ab91432f4557", "82e0d6b73125cdc9428e1f4a39d2a5a1"],
+    "/etc/zshrc":["5c21be339555680489cc7448c92acc18", "8c234b3fb7e4a27f1364df17cb6b22c5"],
     "/etc/bashrc":["7817a5d0c4ebbe0aa5321cf2dd1dcc0b"],
     "/etc/profile":["3a3febb29e55ee975098903a31f8022a"],
     "~/.zprofile":["e37b9b95873a94bf9b5c4566fe3a94c5"]