Skip to content

Commit 27d8d3f

Browse files
committed
- (Bug Fix) Fixed a critical JS issue that was preventing a map from working upon instantiation. Bug was a result of a recent refactor
1 parent 3b49728 commit 27d8d3f

File tree

5 files changed

+31
-22
lines changed

5 files changed

+31
-22
lines changed

resources/js/app.compiled.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10757,8 +10757,10 @@ var GoogleMaps = {
1075710757
savedData: options.savedData,
1075810758
width: options.width,
1075910759
height: options.height,
10760-
position: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
10761-
zoom: options.zoom,
10760+
mapOptions: {
10761+
center: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
10762+
zoom: options.zoom
10763+
},
1076210764
showButtons: options.showButtons,
1076310765
addressFields: options.addressFields
1076410766
});
@@ -12607,13 +12609,14 @@ var GoogleMaps = {
1260712609
this.polylines = [];
1260812610
this.routes = [];
1260912611

12612+
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
12613+
1261012614
this.mapOptions = _.extend({}, {
1261112615
zoom: 8,
1261212616
disableDefaultUI: true,
12613-
mapType: google.maps.MapTypeId.ROADMAP
12614-
});
12615-
12616-
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
12617+
mapType: google.maps.MapTypeId.ROADMAP,
12618+
center: new google.maps.LatLng(0, 0)
12619+
}, (options.mapOptions ? options.mapOptions : {}));
1261712620

1261812621
if(!this.model) {
1261912622
this.model = new Backbone.Model();

resources/js/app.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,10 @@ var GoogleMaps = {
5353
savedData: options.savedData,
5454
width: options.width,
5555
height: options.height,
56-
position: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
57-
zoom: options.zoom,
56+
mapOptions: {
57+
center: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
58+
zoom: options.zoom
59+
},
5860
showButtons: options.showButtons,
5961
addressFields: options.addressFields
6062
});
@@ -1903,13 +1905,14 @@ var GoogleMaps = {
19031905
this.polylines = [];
19041906
this.routes = [];
19051907

1908+
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
1909+
19061910
this.mapOptions = _.extend({}, {
19071911
zoom: 8,
19081912
disableDefaultUI: true,
1909-
mapType: google.maps.MapTypeId.ROADMAP
1910-
});
1911-
1912-
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
1913+
mapType: google.maps.MapTypeId.ROADMAP,
1914+
center: new google.maps.LatLng(0, 0)
1915+
}, (options.mapOptions ? options.mapOptions : {}));
19131916

19141917
if(!this.model) {
19151918
this.model = new Backbone.Model();

resources/js/app.min.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

resources/js/app/main.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,10 @@ var GoogleMaps = {
5353
savedData: options.savedData,
5454
width: options.width,
5555
height: options.height,
56-
position: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
57-
zoom: options.zoom,
56+
mapOptions: {
57+
center: new google.maps.LatLng(parseFloat(coord[0]), parseFloat(coord[1])),
58+
zoom: options.zoom
59+
},
5860
showButtons: options.showButtons,
5961
addressFields: options.addressFields
6062
});

resources/js/app/views/Map.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,14 @@
4949
this.polylines = [];
5050
this.routes = [];
5151

52+
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
53+
5254
this.mapOptions = _.extend({}, {
5355
zoom: 8,
5456
disableDefaultUI: true,
55-
mapType: google.maps.MapTypeId.ROADMAP
56-
});
57-
58-
GoogleMaps.Views.LayoutView.prototype.initialize.call(this, options);
57+
mapType: google.maps.MapTypeId.ROADMAP,
58+
center: new google.maps.LatLng(0, 0)
59+
}, (options.mapOptions ? options.mapOptions : {}));
5960

6061
if(!this.model) {
6162
this.model = new Backbone.Model();

0 commit comments

Comments
 (0)