Skip to content

Commit b656a36

Browse files
Copilothuangyiirene
andcommitted
refactor: Address code review feedback
- Add comment explaining fallback config matches site-config.ts defaults - Only show missing translation warnings in development mode - Improve code quality and production readiness Co-authored-by: huangyiirene <[email protected]>
1 parent 1cef231 commit b656a36

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/cli/src/utils/translate.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ function loadSiteConfig() {
1111

1212
if (!fs.existsSync(configPath)) {
1313
console.warn(`Warning: docs.site.json not found at ${configPath}, using defaults`);
14+
// Fallback matches the default configuration in packages/site/lib/site-config.ts
1415
return {
1516
i18n: {
1617
enabled: true,

packages/site/lib/translations.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,10 @@ export function getTranslations(): Record<string, LanguageTranslations> {
8888
translations[lang] = defaultTranslations[lang];
8989
} else {
9090
// If no translation exists for a configured language, provide a minimal fallback
91-
console.warn(`Warning: No translations found for language "${lang}". Using minimal fallback.`);
91+
// Only log warning in development
92+
if (process.env.NODE_ENV === 'development') {
93+
console.warn(`Warning: No translations found for language "${lang}". Using minimal fallback.`);
94+
}
9295
translations[lang] = {
9396
displayName: lang.toUpperCase(),
9497
};

0 commit comments

Comments
 (0)