Skip to content

Commit 29e9889

Browse files
committed
Fix sidebar CSS variable usage and typo in index.css
Corrects a typo in the CSS variable '--destructive' in index.css and updates sidebar.tsx to use the correct CSS variable syntax for width properties. Also adds sidebar width variables to the CSS for improved maintainability.
1 parent 2cda679 commit 29e9889

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

examples/prototype/src/index.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
--accent: 240 4.8% 95.9%;
2626
--accent-foreground: 240 5.9% 10%;
2727

28-
--destructiuve: 0 84.2% 60.2%;
28+
--destructive: 0 84.2% 60.2%;
2929
--destructive-foreground: 0 0% 98%;
3030

3131
--border: 240 5.9% 90%;
@@ -42,6 +42,9 @@
4242
--sidebar-accent-foreground: 240 5.9% 10%;
4343
--sidebar-border: 220 13% 91%;
4444
--sidebar-ring: 217.2 91.2% 59.8%;
45+
46+
--sidebar-width: 16rem;
47+
--sidebar-width-mobile: 20rem;
4548
}
4649

4750
.dark {

packages/ui/src/components/ui/sidebar.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ function Sidebar({
187187
data-sidebar="sidebar"
188188
data-slot="sidebar"
189189
data-mobile="true"
190-
className="bg-sidebar text-sidebar-foreground w-(--sidebar-width) p-0 [&>button]:hidden"
190+
className="bg-sidebar text-sidebar-foreground w-[--sidebar-width] p-0 [&>button]:hidden"
191191
style={
192192
{
193193
"--sidebar-width": SIDEBAR_WIDTH_MOBILE,
@@ -218,25 +218,25 @@ function Sidebar({
218218
<div
219219
data-slot="sidebar-gap"
220220
className={cn(
221-
"relative w-(--sidebar-width) bg-transparent transition-[width] duration-200 ease-linear",
221+
"relative w-[--sidebar-width] bg-transparent transition-[width] duration-200 ease-linear",
222222
"group-data-[collapsible=offcanvas]:w-0",
223223
"group-data-[side=right]:rotate-180",
224224
variant === "floating" || variant === "inset"
225-
? "group-data-[collapsible=icon]:w-[calc(var(--sidebar-width-icon)+(--spacing(4)))]"
226-
: "group-data-[collapsible=icon]:w-(--sidebar-width-icon)"
225+
? "group-data-[collapsible=icon]:w-[calc(var(--sidebar-width-icon)+1rem)]"
226+
: "group-data-[collapsible=icon]:w-[--sidebar-width-icon]"
227227
)}
228228
/>
229229
<div
230230
data-slot="sidebar-container"
231231
className={cn(
232-
"fixed inset-y-0 z-10 hidden h-svh w-(--sidebar-width) transition-[left,right,width] duration-200 ease-linear md:flex",
232+
"fixed inset-y-0 z-10 hidden h-svh w-[--sidebar-width] transition-[left,right,width] duration-200 ease-linear md:flex",
233233
side === "left"
234234
? "left-0 group-data-[collapsible=offcanvas]:left-[calc(var(--sidebar-width)*-1)]"
235235
: "right-0 group-data-[collapsible=offcanvas]:right-[calc(var(--sidebar-width)*-1)]",
236236
// Adjust the padding for floating and inset variants.
237237
variant === "floating" || variant === "inset"
238-
? "p-2 group-data-[collapsible=icon]:w-[calc(var(--sidebar-width-icon)+(--spacing(4))+2px)]"
239-
: "group-data-[collapsible=icon]:w-(--sidebar-width-icon) group-data-[side=left]:border-r group-data-[side=right]:border-l",
238+
? "p-2 group-data-[collapsible=icon]:w-[calc(var(--sidebar-width-icon)+1rem+2px)]"
239+
: "group-data-[collapsible=icon]:w-[--sidebar-width-icon] group-data-[side=left]:border-r group-data-[side=right]:border-l",
240240
className
241241
)}
242242
{...props}

0 commit comments

Comments
 (0)