From 6259d903b5138e41a0b4abeef68439ac9b7ff249 Mon Sep 17 00:00:00 2001 From: Graeme Coupar Date: Sun, 22 Feb 2026 12:38:02 +0000 Subject: [PATCH] fix: disable warnings in CI also remove the COLUMNS setting that's been fucking up my CLI tests --- .github/workflows/rust.yml | 5 ++--- tests/ui-tests/tests/cases/enum-guess-validation.rs | 1 + tests/ui-tests/tests/cases/enum-guess-validation.stderr | 8 -------- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 9c9e2b225..6ddc8a4d1 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -7,10 +7,9 @@ on: branches: [main] env: - COLUMNS: 250 + COLUMNS: 80 CARGO_INCREMENTAL: 0 - # TODO: Would be nice to disable warnings here too, but there are too many of them. - RUSTFLAGS: "-W rust-2021-compatibility" + RUSTFLAGS: "-W rust-2021-compatibility -D warnings" RUST_BACKTRACE: short NEXTEST_PROFILE: ci CI: 1 diff --git a/tests/ui-tests/tests/cases/enum-guess-validation.rs b/tests/ui-tests/tests/cases/enum-guess-validation.rs index 2c8d7c555..a2f542da4 100644 --- a/tests/ui-tests/tests/cases/enum-guess-validation.rs +++ b/tests/ui-tests/tests/cases/enum-guess-validation.rs @@ -9,6 +9,7 @@ mod schema { schema_path = "../../../../schemas/simple.graphql", graphql_type = "Desseqt" )] +#[allow(non_camel_case_types)] enum Dessert { CHEESECAKE, ICE_CREAM, diff --git a/tests/ui-tests/tests/cases/enum-guess-validation.stderr b/tests/ui-tests/tests/cases/enum-guess-validation.stderr index 13709ec19..62a867f5f 100644 --- a/tests/ui-tests/tests/cases/enum-guess-validation.stderr +++ b/tests/ui-tests/tests/cases/enum-guess-validation.stderr @@ -3,11 +3,3 @@ error: Could not find a type named `Desseqt` in the schema | 10 | graphql_type = "Desseqt" | ^^^^^^^^^ - -warning: variant `ICE_CREAM` should have an upper camel case name - --> tests/cases/enum-guess-validation.rs:14:5 - | -14 | ICE_CREAM, - | ^^^^^^^^^ help: convert the identifier to upper camel case: `IceCream` - | - = note: `#[warn(non_camel_case_types)]` on by default