Skip to content

Commit 4dc94e1

Browse files
author
TinaTiel
authored
Merge pull request #41 from ChristopheCVB/fix/mute
fix: GetMute package
2 parents 0b0c61d + d590776 commit 4dc94e1

File tree

6 files changed

+26
-19
lines changed

6 files changed

+26
-19
lines changed

src/integrationTest/java/net/twasi/obsremotejava/test/manual/ObsRemoteE2eObservationIT.java

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
package net.twasi.obsremotejava.test.manual;
22

3-
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
4-
import static org.junit.jupiter.api.Assertions.fail;
3+
import net.twasi.obsremotejava.requests.GetMute.GetMuteResponse;
4+
import net.twasi.obsremotejava.test.AbstractObsE2ETest;
5+
import org.junit.jupiter.api.*;
56

67
import java.io.File;
78
import java.util.HashMap;
89
import java.util.Map;
9-
import net.twasi.obsremotejava.test.AbstractObsE2ETest;
10-
import org.junit.jupiter.api.AfterAll;
11-
import org.junit.jupiter.api.AfterEach;
12-
import org.junit.jupiter.api.BeforeAll;
13-
import org.junit.jupiter.api.BeforeEach;
14-
import org.junit.jupiter.api.Test;
10+
11+
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
1512

1613
/**
1714
* This test should be run manually, following the prompts in the command-line and
@@ -170,8 +167,16 @@ void setVolumeAndMute() {
170167
remote.setVolume(SOURCE_MEDIA, 0.50, loggingCallback);
171168
obsShould("Mute the volume");
172169
remote.setMute(SOURCE_MEDIA, true, loggingCallback);
170+
remote.getMute(SOURCE_MEDIA, capturingCallback);
171+
waitReasonably();
172+
assertThat(getPreviousResponseAs(GetMuteResponse.class).isMuted()).isTrue();
173+
173174
obsShould("Unmute the volume");
174175
remote.setMute(SOURCE_MEDIA, false, loggingCallback);
176+
remote.getMute(SOURCE_MEDIA, capturingCallback);
177+
waitReasonably();
178+
assertThat(getPreviousResponseAs(GetMuteResponse.class).isMuted()).isFalse();
179+
175180
obsShould("Set the volume to 100%");
176181
remote.setVolume(SOURCE_MEDIA, 1.00, loggingCallback);
177182

src/main/java/net/twasi/obsremotejava/OBSCommunicator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@
102102
import net.twasi.obsremotejava.requests.StopStreaming.StopStreamingResponse;
103103
import net.twasi.obsremotejava.requests.TakeSourceScreenshot.TakeSourceScreenshotRequest;
104104
import net.twasi.obsremotejava.requests.TakeSourceScreenshot.TakeSourceScreenshotResponse;
105-
import net.twasi.obsremotejava.requests.ToggleMute.GetMute.ToggleMuteRequest;
106-
import net.twasi.obsremotejava.requests.ToggleMute.GetMute.ToggleMuteResponse;
105+
import net.twasi.obsremotejava.requests.ToggleMute.ToggleMuteRequest;
106+
import net.twasi.obsremotejava.requests.ToggleMute.ToggleMuteResponse;
107107
import net.twasi.obsremotejava.requests.TransitionToProgram.TransitionToProgramRequest;
108108
import net.twasi.obsremotejava.requests.TransitionToProgram.TransitionToProgramResponse;
109109
import net.twasi.obsremotejava.requests.TriggerHotkeyByName.TriggerHotkeyByNameRequest;
@@ -787,14 +787,14 @@ public void setMute(String source, boolean mute, Consumer<SetMuteResponse> callb
787787
callbacks.put(SetMuteResponse.class, callback);
788788
}
789789

790-
public void getMute(String source, Consumer<SetMuteResponse> callback) {
790+
public void getMute(String source, Consumer<GetMuteResponse> callback) {
791791
GetMuteRequest request = new GetMuteRequest(this, source);
792792

793793
session.getRemote().sendStringByFuture(this.gson.toJson(request));
794794
callbacks.put(GetMuteResponse.class, callback);
795795
}
796796

797-
public void toggleMute(String source, Consumer<SetMuteResponse> callback) {
797+
public void toggleMute(String source, Consumer<ToggleMuteResponse> callback) {
798798
ToggleMuteRequest request = new ToggleMuteRequest(this, source);
799799

800800
session.getRemote().sendStringByFuture(this.gson.toJson(request));

src/main/java/net/twasi/obsremotejava/OBSRemoteController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import net.twasi.obsremotejava.requests.GetAudioMonitorType.GetAudioMonitorTypeResponse;
66
import net.twasi.obsremotejava.requests.GetCurrentProfile.GetCurrentProfileResponse;
77
import net.twasi.obsremotejava.requests.GetCurrentScene.GetCurrentSceneResponse;
8+
import net.twasi.obsremotejava.requests.GetMute.GetMuteResponse;
89
import net.twasi.obsremotejava.requests.GetPreviewScene.GetPreviewSceneResponse;
910
import net.twasi.obsremotejava.requests.GetSceneItemProperties.GetSceneItemPropertiesResponse;
1011
import net.twasi.obsremotejava.requests.GetSceneList.GetSceneListResponse;
@@ -47,6 +48,7 @@
4748
import net.twasi.obsremotejava.requests.StopReplayBuffer.StopReplayBufferResponse;
4849
import net.twasi.obsremotejava.requests.StopStreaming.StopStreamingResponse;
4950
import net.twasi.obsremotejava.requests.TakeSourceScreenshot.TakeSourceScreenshotResponse;
51+
import net.twasi.obsremotejava.requests.ToggleMute.ToggleMuteResponse;
5052
import net.twasi.obsremotejava.requests.TransitionToProgram.TransitionToProgramResponse;
5153
import net.twasi.obsremotejava.requests.TriggerHotkeyByName.TriggerHotkeyByNameResponse;
5254
import org.eclipse.jetty.websocket.api.Session;
@@ -418,11 +420,11 @@ public void setMute(String source, boolean mute, Consumer<SetMuteResponse> callb
418420
communicator.setMute(source, mute, callback);
419421
}
420422

421-
public void getMute(String source, Consumer<SetMuteResponse> callback) {
423+
public void getMute(String source, Consumer<GetMuteResponse> callback) {
422424
communicator.getMute(source, callback);
423425
}
424426

425-
public void toggleMute(String source, Consumer<SetMuteResponse> callback) {
427+
public void toggleMute(String source, Consumer<ToggleMuteResponse> callback) {
426428
communicator.toggleMute(source, callback);
427429
}
428430

src/main/java/net/twasi/obsremotejava/requests/GetMute/GetMuteResponse.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44

55
public class GetMuteResponse extends ResponseBase {
66
private String source;
7-
private boolean mute;
7+
private boolean muted;
88

99
public String getSource() {
1010
return source;
1111
}
1212

13-
public Boolean getMute() {
14-
return mute;
13+
public Boolean isMuted() {
14+
return muted;
1515
}
1616
}

src/main/java/net/twasi/obsremotejava/requests/ToggleMute/GetMute/ToggleMuteRequest.java renamed to src/main/java/net/twasi/obsremotejava/requests/ToggleMute/ToggleMuteRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package net.twasi.obsremotejava.requests.ToggleMute.GetMute;
1+
package net.twasi.obsremotejava.requests.ToggleMute;
22

33
import net.twasi.obsremotejava.OBSCommunicator;
44
import net.twasi.obsremotejava.requests.RequestBase;

src/main/java/net/twasi/obsremotejava/requests/ToggleMute/GetMute/ToggleMuteResponse.java renamed to src/main/java/net/twasi/obsremotejava/requests/ToggleMute/ToggleMuteResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package net.twasi.obsremotejava.requests.ToggleMute.GetMute;
1+
package net.twasi.obsremotejava.requests.ToggleMute;
22

33
import net.twasi.obsremotejava.requests.ResponseBase;
44

0 commit comments

Comments
 (0)