Remove typscript overrides as they were showing worse autocomplete suggestions

Compile typescript definitions separately since emit seems to be missing half the time?

Author: t2t2

package.json

@@ -32,6 +32,7 @@
   "main": "dist/json.cjs",
   "module": "dist/json.module.js",
   "amdName": "OBSWebSocket",
+  "jsdelivr": "dist/obs-ws.min.cjs",
   "unpkg": "dist/obs-ws.min.cjs",
   "types": "dist/json.d.ts",
   "engines": {
@@ -42,12 +43,14 @@
   ],
   "scripts": {
     "build": "npm-run-all clean build:*",
-    "build:bundle": "microbundle -f modern,esm,cjs --no-compress src/{json,msgpack}.ts",
-    "build:unpkg": "microbundle -f iife src/unpkg.ts -o dist/obs-ws.min.js --external none",
+    "build:bundle": "microbundle -f modern,esm,cjs --no-compress src/{json,msgpack}.ts --generateTypes false",
+    "build:types": "tsc --emitDeclarationOnly",
+    "build:unpkg": "microbundle -f iife src/unpkg.ts -o dist/obs-ws.min.js --external none --generateTypes false",
     "clean": "rimraf dist",
     "dev": "npm run build:bundle -- --watch",
     "generate:obs-types": "node --loader=ts-node/esm scripts/build-types.ts",
     "lint": "eslint . --ext .cjs,.js,.ts",
+    "prepare": "npm run build",
     "report": "c8 report",
     "test": "c8 ava",
     "test:watch": "ava --watch"

scripts/build-types.ts

@@ -243,15 +243,16 @@ export interface OBSRequestTypes {
 export interface OBSResponseTypes {
 	${generateObsResponseTypes(protocol.requests)}
 }
-
+`;
+/* typescript provides worse autocomplete results and errors with these
 // Overrides to improve typescript for requests without data and to provide documentation
 declare module './base' {
 	interface BaseOBSWebSocket {
 		${generateObsRequestOverrides(protocol.requests)}
 		${generateObsListenerOverrides(protocol.events)}
 	}
 }
-`;
+*/
 
 const linter = new ESLint({fix: true});
 const linted = await linter.lintText(source, {
@@ -310,7 +311,7 @@ function generateObsEventTypes(events: OBSEvent[]): string {
 function generateObsRequestTypes(requests: OBSRequest[]): string {
 	return requests.map(req => {
 		if (req.requestFields.length === 0) {
-			return `${req.requestType}: undefined;`;
+			return `${req.requestType}: never;`;
 		}
 
 		return `${req.requestType}: ${stringifyTypes(unflattenAndResolveTypes(req.requestFields))};`;
@@ -327,6 +328,7 @@ function generateObsResponseTypes(requests: OBSRequest[]): string {
 	}).join('\n');
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function generateObsListenerOverrides(events: OBSEvent[]): string {
 	return events.map(ev => {
 		const jsdoc: string[] = [
@@ -348,6 +350,7 @@ function generateObsListenerOverrides(events: OBSEvent[]): string {
 	}).join('\n');
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function generateObsRequestOverrides(requests: OBSRequest[]): string {
 	return requests.map(req => {
 		const jsdoc: string[] = [
@@ -364,7 +367,7 @@ function generateObsRequestOverrides(requests: OBSRequest[]): string {
 
 		const requestData = req.requestFields.length > 0
 			? `requestData: OBSRequestTypes['${req.requestType}']`
-			: 'requestData?: undefined';
+			: 'requestData?: never';
 
 		return [
 			formatJsDoc(jsdoc),

src/base.ts

@@ -123,7 +123,7 @@ export abstract class BaseOBSWebSocket extends EventEmitter<MapValueToArgsArray<
 	 * @param requestData Request data
 	 * @returns Request response
 	 */
-	async call<Type extends keyof OBSRequestTypes>(requestType: Type, requestData: OBSRequestTypes[Type]): Promise<OBSResponseTypes[Type]> {
+	async call<Type extends keyof OBSRequestTypes>(requestType: Type, requestData?: OBSRequestTypes[Type]): Promise<OBSResponseTypes[Type]> {
 		const requestId = BaseOBSWebSocket.generateMessageId();
 		const responsePromise = this.internalEventPromise<ResponseMessage<Type>>(`res:${requestId}`);
 		await this.message(WebSocketOpCode.Request, {