add test for polling for repo auth; deploy.ts test coverage is now back up to status quo ante; fix polling for auth to respect deployOptions.deployPollInterval, though one could argue its now too narrowly named

Author: Observable User

src/deploy.ts

@@ -311,6 +311,8 @@ class Deployer {
         providerId: source.provider_id
       });
       if (!remoteAuthedRepo) {
+        // TODO: This could poll for auth too, but is a distinct case because it
+        // means the repo was linked at one point and then something went wrong
         throw new CliError(
           `Cannot access configured repository; check build settings on ${link(
             `${settingsUrl(deployTarget)}/settings`
@@ -336,9 +338,10 @@ class Deployer {
 
       const spinner = this.effects.clack.spinner();
       spinner.start("Waiting for repository to be authorized");
+      const {deployPollInterval: pollInterval = DEPLOY_POLL_INTERVAL_MS} = this.deployOptions;
       const pollExpiration = Date.now() + DEPLOY_POLL_MAX_MS;
       while (!localRepo) {
-        await new Promise((resolve) => setTimeout(resolve, 2000));
+        await new Promise((resolve) => setTimeout(resolve, pollInterval));
         if (Date.now() > pollExpiration) {
           spinner.stop("Waiting for repository to be authorized timed out.");
           throw new CliError("Repository authorization failed");

test/deploy-test.ts

@@ -300,6 +300,41 @@ describe("deploy", () => {
       effects.close();
     });
 
+    it("starts cloud build when continuous deployment is enabled for new project and repo is manually auth’ed while CLI is polling", async () => {
+      const deployId = "deploy123";
+      getCurrentObservableApi()
+        .handleGetCurrentUser()
+        .handleGetWorkspaceProjects({
+          workspaceLogin: DEPLOY_CONFIG.workspaceLogin,
+          projects: []
+        })
+        .handlePostProject({projectId: DEPLOY_CONFIG.projectId, slug: DEPLOY_CONFIG.projectSlug})
+        .handleGetRepository({status: 404})
+        .handleGetRepository()
+        .handlePostProjectEnvironment()
+        .handlePostProjectBuild()
+        .handleGetProject({...DEPLOY_CONFIG, latestCreatedDeployId: deployId})
+        .handleGetDeploy({deployId, deployStatus: "uploaded"})
+        .start();
+      const effects = new MockDeployEffects();
+      effects.clack.inputs.push(
+        true, // No apps found. Do you want to create a new app?
+        DEPLOY_CONFIG.projectSlug, // What slug do you want to use?
+        "public", // Who is allowed to access your app?
+        true // Do you want to enable continuous deployment?
+      );
+
+      await (await open("readme.md", "a")).close();
+      const {stdout, stderr} = await promisify(exec)(
+        "git add . && git commit -m 'initial' && git remote add origin [email protected]:observablehq/test.git"
+      );
+      console.log("starts cloud build test", {stdout, stderr});
+
+      await deploy(TEST_OPTIONS, effects);
+
+      effects.close();
+    });
+
     it("starts cloud build when continuous deployment is enabled for existing project with existing source", async () => {
       const deployId = "deploy123";
       getCurrentObservableApi()