Skip to content

Commit e523424

Browse files
authored
↗︎ for external sidebar links (#1342)
1 parent 2a54e8e commit e523424

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

docs/style.css

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,21 @@
66
color: inherit;
77
}
88

9-
#observablehq-header a[target="_blank"] {
9+
#observablehq-header a[target="_blank"],
10+
.observablehq-link a[target="_blank"] {
1011
display: flex;
1112
align-items: center;
1213
gap: 0.25rem;
1314
text-decoration: none;
1415
}
1516

16-
#observablehq-header a[target="_blank"]:hover span {
17+
#observablehq-header a[target="_blank"]:hover span,
18+
.observablehq-link a[target="_blank"]:hover span {
1719
text-decoration: underline;
1820
}
1921

20-
#observablehq-header a[target="_blank"]::after {
22+
#observablehq-header a[target="_blank"]::after,
23+
.observablehq-link a[target="_blank"]::after {
2124
content: "\2197";
2225
}
2326

@@ -29,6 +32,10 @@
2932
color: var(--theme-foreground-muted);
3033
}
3134

35+
.observablehq-link a[target="_blank"]:not(:hover, :focus)::after {
36+
color: var(--theme-foreground-faint);
37+
}
38+
3239
#observablehq-main {
3340
min-height: calc(100vh - 23.8rem);
3441
}

src/render.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,11 @@ function renderToc(headers: Header[], label: string): Html {
197197
}
198198

199199
function renderListItem(page: Page, path: string, resolveLink: (href: string) => string): Html {
200+
const external = !isAssetPath(page.path);
200201
return html`\n <li class="observablehq-link${
201202
normalizePath(page.path) === path ? " observablehq-link-active" : ""
202-
}"><a href="${encodeURI(resolveLink(page.path))}"${isAssetPath(page.path) ? null : html` target="_blank"`}>${
203-
page.name
203+
}"><a href="${encodeURI(resolveLink(page.path))}"${external ? html` target="_blank"` : null}>${
204+
external ? html`<span>${page.name}</span>` : page.name
204205
}</a></li>`;
205206
}
206207

0 commit comments

Comments
 (0)