Skip to content

Commit ea676b1

Browse files
committed
dont change continuousDeployment setting as a side effect of github link failing
1 parent e80786b commit ea676b1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/deploy.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ class Deployer {
253253
.filter((d) => d)
254254
.map((d) => d.split(/\s/g));
255255
const gitHub = remotes.find(([, url]) => url.startsWith("https://github.com/"));
256+
// TODO: validate "Your branch is up to date" & "nothing to commit, working tree clean"
256257
if (gitHub) {
257258
const [ownerName, repoName] = formatGitUrl(gitHub[1]).split("/");
258259
// Get current branch
@@ -522,7 +523,7 @@ class Deployer {
522523
}
523524

524525
// Disables continuous deployment if there’s no env/source & we can’t link GitHub
525-
if (continuousDeployment) continuousDeployment = await this.maybeLinkGitHub(deployTarget);
526+
if (continuousDeployment) await this.maybeLinkGitHub(deployTarget);
526527

527528
const newDeployConfig = {
528529
projectId: deployTarget.project.id,

0 commit comments

Comments
 (0)