Skip to content

Commit 7c2c044

Browse files
committed
fix FileAttachment types
1 parent 0b461d6 commit 7c2c044

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/runtime/stdlib/fileAttachment.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,16 @@ export interface FileAttachment {
1010
href: string;
1111
lastModified: number | undefined;
1212
size: number | undefined;
13-
url(): Promise<string>; // deprecated! use href
13+
/** @deprecated use FileAttachment.href instead */
14+
url(): Promise<string>;
1415
blob(): Promise<Blob>;
1516
arrayBuffer(): Promise<ArrayBuffer>;
1617
text(encoding?: string): Promise<string>;
1718
json(): Promise<any>;
1819
stream(): Promise<ReadableStream<Uint8Array<ArrayBufferLike>>>;
1920
dsv(options?: DsvOptions): Promise<DsvResult>;
20-
csv(options?: Exclude<DsvOptions, "delimiter">): Promise<DsvResult>;
21-
tsv(options?: Exclude<DsvOptions, "delimiter">): Promise<DsvResult>;
21+
csv(options?: Omit<DsvOptions, "delimiter">): Promise<DsvResult>;
22+
tsv(options?: Omit<DsvOptions, "delimiter">): Promise<DsvResult>;
2223
image(props?: Partial<HTMLImageElement>): Promise<HTMLImageElement>;
2324
arrow(): Promise<any>;
2425
arquero(options?: any): Promise<any>;
@@ -89,10 +90,10 @@ export abstract class AbstractFile implements FileAttachment {
8990
const parse = array ? format.parseRows : format.parse;
9091
return parse(text, typed && d3.autoType);
9192
}
92-
async csv(options: Exclude<DsvOptions, "delimiter">): Promise<DsvResult> {
93+
async csv(options?: Omit<DsvOptions, "delimiter">): Promise<DsvResult> {
9394
return this.dsv({...options, delimiter: ","});
9495
}
95-
async tsv(options: Exclude<DsvOptions, "delimiter">): Promise<DsvResult> {
96+
async tsv(options?: Omit<DsvOptions, "delimiter">): Promise<DsvResult> {
9697
return this.dsv({...options, delimiter: "\t"});
9798
}
9899
async image(props?: Partial<HTMLImageElement>): Promise<HTMLImageElement> {

0 commit comments

Comments
 (0)